Skip to content

Add Azure ManagedCleanroom toolset with first commands: collaborations list and collaboration create#2882

Open
ShreyaSangwa wants to merge 22 commits into
microsoft:mainfrom
ShreyaSangwa:cleanrooms
Open

Add Azure ManagedCleanroom toolset with first commands: collaborations list and collaboration create#2882
ShreyaSangwa wants to merge 22 commits into
microsoft:mainfrom
ShreyaSangwa:cleanrooms

Conversation

@ShreyaSangwa

@ShreyaSangwa ShreyaSangwa commented Jun 15, 2026

Copy link
Copy Markdown

What does this PR do?

Introduces the initial Azure ManagedCleanroom implementation in Azure MCP with two commands.

Commands added:

  • managedcleanroom collaborations list
  • managedcleanroom collaboration create

Implemented in this PR:

  • Added initial ManagedCleanroom command registration for the two commands above.
  • Added command implementations and option wiring for:
    • collaborations list
    • collaboration create
  • Added/updated supporting setup so both commands are discoverable in Azure MCP.
  • Applied related review follow-ups and metadata/doc consistency updates required for this initial slice.

Validation performed:

  • Build succeeded for the ManagedCleanroom toolset.
  • Build succeeded for supporting metadata/exporter tooling used by this PR.
  • Targeted command checks for the first two commands (managedcleanroom collaborations list and managedcleanroom collaboration create) are validated in this PR scope.

Pre-merge Checklist

  • Required for All PRs
    • Read contribution guidelines
    • PR title clearly describes the change
    • Commit history is clean with descriptive messages (cleanup guide)
    • Added comprehensive tests for new/modified functionality
    • Created a changelog entry if the change falls among the following: new feature, bug fix, UI/UX update, breaking change, or updated dependencies. Follow the changelog entry guide
  • For MCP tool changes:
    • One tool per PR: This PR adds or modifies only one MCP tool for faster review cycles
    • Updated servers/Azure.Mcp.Server/README.md and/or servers/Fabric.Mcp.Server/README.md documentation
    • Validate README.md changes running the script ./eng/scripts/Process-PackageReadMe.ps1. See Package README
    • For new or modified tool descriptions, ran ToolDescriptionEvaluator and obtained a score of 0.4 or more and a top 3 ranking for all related test prompts
    • For tools with new names, including new tools or renamed tools, update consolidated-tools.json
    • For renamed tools, follow the Tool Rename Checklist and tag the PR with the breaking-change label
    • For new tools associated with Azure services or publicly available tools/APIs/products, add URL to documentation in the PR description
  • Extra steps for Azure MCP Server tool changes:
    • Updated command list in servers/Azure.Mcp.Server/docs/azmcp-commands.md
    • Ran ./eng/scripts/Update-AzCommandsMetadata.ps1 to update tool metadata in azmcp-commands.md (required for CI)
    • Updated test prompts in servers/Azure.Mcp.Server/docs/e2eTestPrompts.md
    • 👉 For Community (non-Microsoft team member) PRs:
      • Security review: Reviewed code for security vulnerabilities, malicious code, or suspicious activities before running tests (crypto mining, spam, data exfiltration, etc.)
      • Manual tests run: added comment /azp run mcp - pullrequest - live to run Live Test Pipeline

@ShreyaSangwa ShreyaSangwa requested review from a team as code owners June 15, 2026 12:12
@github-actions

github-actions Bot commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

Thank you for your contribution @ShreyaSangwa! We will review the pull request and get back to you soon.

Copilot AI reviewed Jun 15, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Adds a new Azure Managed Cleanroom tool area to the Azure MCP Server, including command implementations, test scaffolding, and documentation/metadata updates to expose the new commands through the server.

Changes:

  • Introduces Azure.Mcp.Tools.ManagedCleanroom tool project with multiple data-plane and ARM-plane commands plus shared option models and JSON source-gen context.
  • Adds a dedicated unit test project with command-level tests and live-test resource templates/scripts.
  • Updates server registration, tool-metadata consolidation, and documentation (command reference + E2E prompts + changelog entries).

Reviewed changes

Copilot reviewed 125 out of 125 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
tools/Azure.Mcp.Tools.ManagedCleanroom/tests/test-resources.bicep Adds test deployment resources/outputs for Managed Cleanroom live tests.
tools/Azure.Mcp.Tools.ManagedCleanroom/tests/test-resources-post.ps1 Adds post-deploy script to persist test settings and warn when endpoint not provided.
tools/Azure.Mcp.Tools.ManagedCleanroom/tests/Azure.Mcp.Tools.ManagedCleanroom.Tests/assets.json Adds assets tagging config for the new test project.
tools/Azure.Mcp.Tools.ManagedCleanroom/tests/Azure.Mcp.Tools.ManagedCleanroom.Tests/Usings.cs Adds global test using for xUnit.
tools/Azure.Mcp.Tools.ManagedCleanroom/tests/Azure.Mcp.Tools.ManagedCleanroom.Tests/Runs/RunsGetCommandTests.cs Adds unit tests for managedcleanroom runs get.
tools/Azure.Mcp.Tools.ManagedCleanroom/tests/Azure.Mcp.Tools.ManagedCleanroom.Tests/Queries/QueriesVoteCommandTests.cs Adds unit tests for managedcleanroom queries vote.
tools/Azure.Mcp.Tools.ManagedCleanroom/tests/Azure.Mcp.Tools.ManagedCleanroom.Tests/Queries/QueriesRunsCommandTests.cs Adds unit tests for managedcleanroom queries runs.
tools/Azure.Mcp.Tools.ManagedCleanroom/tests/Azure.Mcp.Tools.ManagedCleanroom.Tests/Queries/QueriesRunCommandTests.cs Adds unit tests for managedcleanroom queries run.
tools/Azure.Mcp.Tools.ManagedCleanroom/tests/Azure.Mcp.Tools.ManagedCleanroom.Tests/Queries/QueriesPublishCommandTests.cs Adds unit tests for managedcleanroom queries publish.
tools/Azure.Mcp.Tools.ManagedCleanroom/tests/Azure.Mcp.Tools.ManagedCleanroom.Tests/Queries/QueriesListCommandTests.cs Adds unit tests for managedcleanroom queries list.
tools/Azure.Mcp.Tools.ManagedCleanroom/tests/Azure.Mcp.Tools.ManagedCleanroom.Tests/Queries/QueriesGetCommandTests.cs Adds unit tests for managedcleanroom queries get.
tools/Azure.Mcp.Tools.ManagedCleanroom/tests/Azure.Mcp.Tools.ManagedCleanroom.Tests/Oidc/OidcSetIssuerUrlCommandTests.cs Adds unit tests for managedcleanroom oidc set-issuer-url.
tools/Azure.Mcp.Tools.ManagedCleanroom/tests/Azure.Mcp.Tools.ManagedCleanroom.Tests/Oidc/OidcKeysCommandTests.cs Adds unit tests for managedcleanroom oidc keys.
tools/Azure.Mcp.Tools.ManagedCleanroom/tests/Azure.Mcp.Tools.ManagedCleanroom.Tests/Oidc/OidcIssuerInfoCommandTests.cs Adds unit tests for managedcleanroom oidc issuer-info.
tools/Azure.Mcp.Tools.ManagedCleanroom/tests/Azure.Mcp.Tools.ManagedCleanroom.Tests/Invitations/InvitationsListCommandTests.cs Adds unit tests for managedcleanroom invitations list.
tools/Azure.Mcp.Tools.ManagedCleanroom/tests/Azure.Mcp.Tools.ManagedCleanroom.Tests/Invitations/InvitationsAcceptCommandTests.cs Adds unit tests for managedcleanroom invitations accept.
tools/Azure.Mcp.Tools.ManagedCleanroom/tests/Azure.Mcp.Tools.ManagedCleanroom.Tests/Datasets/DatasetsPublishCommandTests.cs Adds unit tests for managedcleanroom datasets publish.
tools/Azure.Mcp.Tools.ManagedCleanroom/tests/Azure.Mcp.Tools.ManagedCleanroom.Tests/Datasets/DatasetsListCommandTests.cs Adds unit tests for managedcleanroom datasets list.
tools/Azure.Mcp.Tools.ManagedCleanroom/tests/Azure.Mcp.Tools.ManagedCleanroom.Tests/Datasets/DatasetsGetCommandTests.cs Adds unit tests for managedcleanroom datasets get.
tools/Azure.Mcp.Tools.ManagedCleanroom/tests/Azure.Mcp.Tools.ManagedCleanroom.Tests/Consent/ConsentPutCommandTests.cs Adds unit tests for managedcleanroom consent put.
tools/Azure.Mcp.Tools.ManagedCleanroom/tests/Azure.Mcp.Tools.ManagedCleanroom.Tests/Collaborations/CollaborationsListCommandTests.cs Adds unit tests for managedcleanroom collaborations list.
tools/Azure.Mcp.Tools.ManagedCleanroom/tests/Azure.Mcp.Tools.ManagedCleanroom.Tests/Collaborations/CollaborationsGetCommandTests.cs Adds unit tests for managedcleanroom collaborations get.
tools/Azure.Mcp.Tools.ManagedCleanroom/tests/Azure.Mcp.Tools.ManagedCleanroom.Tests/Collaboration/CollaborationGetReadonlyKubeconfigCommandTests.cs Adds unit tests for ARM kubeconfig retrieval command.
tools/Azure.Mcp.Tools.ManagedCleanroom/tests/Azure.Mcp.Tools.ManagedCleanroom.Tests/Collaboration/CollaborationGetCommandTests.cs Adds unit tests for ARM collaboration get command.
tools/Azure.Mcp.Tools.ManagedCleanroom/tests/Azure.Mcp.Tools.ManagedCleanroom.Tests/Collaboration/CollaborationEnableWorkloadCommandTests.cs Adds unit tests for ARM workload enable command.
tools/Azure.Mcp.Tools.ManagedCleanroom/tests/Azure.Mcp.Tools.ManagedCleanroom.Tests/Collaboration/CollaborationCreateCommandTests.cs Adds unit tests for ARM collaboration create command.
tools/Azure.Mcp.Tools.ManagedCleanroom/tests/Azure.Mcp.Tools.ManagedCleanroom.Tests/Collaboration/CollaborationAddCollaboratorCommandTests.cs Adds unit tests for ARM add-collaborator command.
tools/Azure.Mcp.Tools.ManagedCleanroom/tests/Azure.Mcp.Tools.ManagedCleanroom.Tests/Azure.Mcp.Tools.ManagedCleanroom.Tests.csproj Adds new test project + dependencies.
tools/Azure.Mcp.Tools.ManagedCleanroom/tests/Azure.Mcp.Tools.ManagedCleanroom.Tests/AuditEvents/AuditEventsListCommandTests.cs Adds unit tests for managedcleanroom auditevents list.
tools/Azure.Mcp.Tools.ManagedCleanroom/tests/Azure.Mcp.Tools.ManagedCleanroom.Tests/AssemblyAttributes.cs Adds test assembly attributes for env cleanup/collection behavior.
tools/Azure.Mcp.Tools.ManagedCleanroom/tests/Azure.Mcp.Tools.ManagedCleanroom.Tests/Analytics/AnalyticsSkrPolicyCommandTests.cs Adds unit tests for analytics SKR policy command.
tools/Azure.Mcp.Tools.ManagedCleanroom/tests/Azure.Mcp.Tools.ManagedCleanroom.Tests/Analytics/AnalyticsGetCommandTests.cs Adds unit tests for analytics get command.
tools/Azure.Mcp.Tools.ManagedCleanroom/src/Services/ManagedCleanroomSerializerContext.cs Adds JSON source-gen context for JsonElement.
tools/Azure.Mcp.Tools.ManagedCleanroom/src/Services/IManagedCleanroomService.cs Defines service interface for all Managed Cleanroom operations.
tools/Azure.Mcp.Tools.ManagedCleanroom/src/Options/Runs/RunsGetOptions.cs Adds CLI options model for runs get.
tools/Azure.Mcp.Tools.ManagedCleanroom/src/Options/Queries/QueriesVoteOptions.cs Adds CLI options model for queries vote.
tools/Azure.Mcp.Tools.ManagedCleanroom/src/Options/Queries/QueriesRunsOptions.cs Adds CLI options model for queries runs.
tools/Azure.Mcp.Tools.ManagedCleanroom/src/Options/Queries/QueriesRunOptions.cs Adds CLI options model for queries run.
tools/Azure.Mcp.Tools.ManagedCleanroom/src/Options/Queries/QueriesPublishOptions.cs Adds CLI options model for queries publish.
tools/Azure.Mcp.Tools.ManagedCleanroom/src/Options/Queries/QueriesListOptions.cs Adds CLI options model for queries list.
tools/Azure.Mcp.Tools.ManagedCleanroom/src/Options/Queries/QueriesGetOptions.cs Adds CLI options model for queries get.
tools/Azure.Mcp.Tools.ManagedCleanroom/src/Options/Oidc/OidcSetIssuerUrlOptions.cs Adds CLI options model for OIDC issuer registration.
tools/Azure.Mcp.Tools.ManagedCleanroom/src/Options/Oidc/OidcKeysOptions.cs Adds CLI options model for OIDC keys.
tools/Azure.Mcp.Tools.ManagedCleanroom/src/Options/Oidc/OidcIssuerInfoOptions.cs Adds CLI options model for OIDC issuer info.
tools/Azure.Mcp.Tools.ManagedCleanroom/src/Options/ManagedCleanroomOptionDescriptions.cs Adds shared option description constants.
tools/Azure.Mcp.Tools.ManagedCleanroom/src/Options/Invitations/InvitationsListOptions.cs Adds CLI options model for invitations list.
tools/Azure.Mcp.Tools.ManagedCleanroom/src/Options/Invitations/InvitationsAcceptOptions.cs Adds CLI options model for invitations accept.
tools/Azure.Mcp.Tools.ManagedCleanroom/src/Options/Datasets/DatasetsPublishOptions.cs Adds CLI options model for datasets publish.
tools/Azure.Mcp.Tools.ManagedCleanroom/src/Options/Datasets/DatasetsListOptions.cs Adds CLI options model for datasets list.
tools/Azure.Mcp.Tools.ManagedCleanroom/src/Options/Datasets/DatasetsGetOptions.cs Adds CLI options model for datasets get.
tools/Azure.Mcp.Tools.ManagedCleanroom/src/Options/Consent/ConsentPutOptions.cs Adds CLI options model for consent put.
tools/Azure.Mcp.Tools.ManagedCleanroom/src/Options/Collaborations/CollaborationsListOptions.cs Adds CLI options model for collaborations list.
tools/Azure.Mcp.Tools.ManagedCleanroom/src/Options/Collaborations/CollaborationsGetOptions.cs Adds CLI options model for collaborations get.
tools/Azure.Mcp.Tools.ManagedCleanroom/src/Options/Collaboration/CollaborationGetReadonlyKubeconfigOptions.cs Adds CLI options for ARM kubeconfig command.
tools/Azure.Mcp.Tools.ManagedCleanroom/src/Options/Collaboration/CollaborationGetOptions.cs Adds CLI options for ARM get command.
tools/Azure.Mcp.Tools.ManagedCleanroom/src/Options/Collaboration/CollaborationEnableWorkloadOptions.cs Adds CLI options for ARM enable-workload command.
tools/Azure.Mcp.Tools.ManagedCleanroom/src/Options/Collaboration/CollaborationCreateOptions.cs Adds CLI options for ARM create command.
tools/Azure.Mcp.Tools.ManagedCleanroom/src/Options/Collaboration/CollaborationAddCollaboratorOptions.cs Adds CLI options for ARM add-collaborator command.
tools/Azure.Mcp.Tools.ManagedCleanroom/src/Options/AuditEvents/AuditEventsListOptions.cs Adds CLI options for audit events list.
tools/Azure.Mcp.Tools.ManagedCleanroom/src/Options/Analytics/AnalyticsSkrPolicyOptions.cs Adds CLI options for SKR policy.
tools/Azure.Mcp.Tools.ManagedCleanroom/src/Options/Analytics/AnalyticsGetOptions.cs Adds CLI options for analytics get.
tools/Azure.Mcp.Tools.ManagedCleanroom/src/ManagedCleanroomSetup.cs Registers the new area + command groups for Managed Cleanroom.
tools/Azure.Mcp.Tools.ManagedCleanroom/src/Commands/Runs/RunsGetCommand.cs Implements managedcleanroom runs get.
tools/Azure.Mcp.Tools.ManagedCleanroom/src/Commands/Queries/QueriesVoteCommand.cs Implements managedcleanroom queries vote.
tools/Azure.Mcp.Tools.ManagedCleanroom/src/Commands/Queries/QueriesRunsCommand.cs Implements managedcleanroom queries runs.
tools/Azure.Mcp.Tools.ManagedCleanroom/src/Commands/Queries/QueriesRunCommand.cs Implements managedcleanroom queries run.
tools/Azure.Mcp.Tools.ManagedCleanroom/src/Commands/Queries/QueriesPublishCommand.cs Implements managedcleanroom queries publish.
tools/Azure.Mcp.Tools.ManagedCleanroom/src/Commands/Queries/QueriesListCommand.cs Implements managedcleanroom queries list.
tools/Azure.Mcp.Tools.ManagedCleanroom/src/Commands/Queries/QueriesGetCommand.cs Implements managedcleanroom queries get.
tools/Azure.Mcp.Tools.ManagedCleanroom/src/Commands/Oidc/OidcSetIssuerUrlCommand.cs Implements managedcleanroom oidc set-issuer-url.
tools/Azure.Mcp.Tools.ManagedCleanroom/src/Commands/Oidc/OidcKeysCommand.cs Implements managedcleanroom oidc keys.
tools/Azure.Mcp.Tools.ManagedCleanroom/src/Commands/Oidc/OidcIssuerInfoCommand.cs Implements managedcleanroom oidc issuer-info.
tools/Azure.Mcp.Tools.ManagedCleanroom/src/Commands/ManagedCleanroomJsonContext.cs Adds JSON source-gen context used by commands.
tools/Azure.Mcp.Tools.ManagedCleanroom/src/Commands/Invitations/InvitationsListCommand.cs Implements managedcleanroom invitations list.
tools/Azure.Mcp.Tools.ManagedCleanroom/src/Commands/Invitations/InvitationsAcceptCommand.cs Implements managedcleanroom invitations accept.
tools/Azure.Mcp.Tools.ManagedCleanroom/src/Commands/Datasets/DatasetsPublishCommand.cs Implements managedcleanroom datasets publish.
tools/Azure.Mcp.Tools.ManagedCleanroom/src/Commands/Datasets/DatasetsListCommand.cs Implements managedcleanroom datasets list.
tools/Azure.Mcp.Tools.ManagedCleanroom/src/Commands/Datasets/DatasetsGetCommand.cs Implements managedcleanroom datasets get.
tools/Azure.Mcp.Tools.ManagedCleanroom/src/Commands/Consent/ConsentPutCommand.cs Implements managedcleanroom consent put.
tools/Azure.Mcp.Tools.ManagedCleanroom/src/Commands/Collaborations/CollaborationsListCommand.cs Implements managedcleanroom collaborations list.
tools/Azure.Mcp.Tools.ManagedCleanroom/src/Commands/Collaborations/CollaborationsGetCommand.cs Implements managedcleanroom collaborations get.
tools/Azure.Mcp.Tools.ManagedCleanroom/src/Commands/Collaboration/CollaborationGetReadonlyKubeconfigCommand.cs Implements managedcleanroom collaboration get-readonly-kubeconfig.
tools/Azure.Mcp.Tools.ManagedCleanroom/src/Commands/Collaboration/CollaborationGetCommand.cs Implements managedcleanroom collaboration get.
tools/Azure.Mcp.Tools.ManagedCleanroom/src/Commands/Collaboration/CollaborationEnableWorkloadCommand.cs Implements managedcleanroom collaboration enable-workload.
tools/Azure.Mcp.Tools.ManagedCleanroom/src/Commands/Collaboration/CollaborationCreateCommand.cs Implements managedcleanroom collaboration create.
tools/Azure.Mcp.Tools.ManagedCleanroom/src/Commands/Collaboration/CollaborationAddCollaboratorCommand.cs Implements managedcleanroom collaboration add-collaborator.
tools/Azure.Mcp.Tools.ManagedCleanroom/src/Commands/AuditEvents/AuditEventsListCommand.cs Implements managedcleanroom auditevents list.
tools/Azure.Mcp.Tools.ManagedCleanroom/src/Commands/Analytics/AnalyticsSkrPolicyCommand.cs Implements managedcleanroom analytics skr-policy.
tools/Azure.Mcp.Tools.ManagedCleanroom/src/Commands/Analytics/AnalyticsGetCommand.cs Implements managedcleanroom analytics get.
tools/Azure.Mcp.Tools.ManagedCleanroom/src/Azure.Mcp.Tools.ManagedCleanroom.csproj Adds the new tool project and dependencies.
tools/Azure.Mcp.Tools.ManagedCleanroom/src/AssemblyInfo.cs Exposes internals to the test assembly.
servers/Azure.Mcp.Server/src/Resources/consolidated-tools.json Adds consolidated tool groupings mapping to managedcleanroom commands.
servers/Azure.Mcp.Server/src/Program.cs Registers the new Managed Cleanroom area in the server.
servers/Azure.Mcp.Server/docs/e2eTestPrompts.md Adds E2E prompt coverage entries for managedcleanroom tools.
servers/Azure.Mcp.Server/docs/azmcp-commands.md Adds CLI help/reference section for managedcleanroom commands.
servers/Azure.Mcp.Server/changelog-entries/managedcleanroom-runs-get.yaml Adds changelog entry for runs get command.
servers/Azure.Mcp.Server/changelog-entries/managedcleanroom-queries-vote.yaml Adds changelog entry for queries vote command.
servers/Azure.Mcp.Server/changelog-entries/managedcleanroom-queries-runs.yaml Adds changelog entry for queries runs command.
servers/Azure.Mcp.Server/changelog-entries/managedcleanroom-queries-run.yaml Adds changelog entry for queries run command.
servers/Azure.Mcp.Server/changelog-entries/managedcleanroom-queries-publish.yaml Adds changelog entry for queries publish command.
servers/Azure.Mcp.Server/changelog-entries/managedcleanroom-queries-list.yaml Adds changelog entry for queries list command.
servers/Azure.Mcp.Server/changelog-entries/managedcleanroom-queries-get.yaml Adds changelog entry for queries get command.
servers/Azure.Mcp.Server/changelog-entries/managedcleanroom-oidc-set-issuer-url.yaml Adds changelog entry for OIDC set issuer URL command.
servers/Azure.Mcp.Server/changelog-entries/managedcleanroom-oidc-keys.yaml Adds changelog entry for OIDC keys command.
servers/Azure.Mcp.Server/changelog-entries/managedcleanroom-invitations-list.yaml Adds changelog entry for invitations list command.
servers/Azure.Mcp.Server/changelog-entries/managedcleanroom-invitations-accept.yaml Adds changelog entry for invitations accept command.
servers/Azure.Mcp.Server/changelog-entries/managedcleanroom-datasets-publish.yaml Adds changelog entry for datasets publish command.
servers/Azure.Mcp.Server/changelog-entries/managedcleanroom-datasets-list.yaml Adds changelog entry for datasets list command.
servers/Azure.Mcp.Server/changelog-entries/managedcleanroom-datasets-get.yaml Adds changelog entry for datasets get command.
servers/Azure.Mcp.Server/changelog-entries/managedcleanroom-consent-put.yaml Adds changelog entry for consent put command.
servers/Azure.Mcp.Server/changelog-entries/managedcleanroom-collaboration-get.yaml Adds changelog entry for ARM collaboration get command.
servers/Azure.Mcp.Server/changelog-entries/managedcleanroom-collaboration-get-readonly-kubeconfig.yaml Adds changelog entry for kubeconfig command.
servers/Azure.Mcp.Server/changelog-entries/managedcleanroom-auditevents-list.yaml Adds changelog entry for audit events list command.
servers/Azure.Mcp.Server/changelog-entries/1780647747781.yaml Adds a rolled-up changelog entry for Managed Cleanroom toolset.
servers/Azure.Mcp.Server/CHANGELOG.md Adds top-level changelog bullets for new collaboration ARM commands.
servers/Azure.Mcp.Server/Azure.Mcp.Server.slnx Adds Managed Cleanroom source + test projects to server solution.
nuget.config Adds a local package source intended for Managed Cleanroom dependencies.
eng/tools/ToolMetadataExporter/src/Program.cs Adjusts Managed Identity credential initialization.
Microsoft.Mcp.slnx Adds Managed Cleanroom projects to the root solution.
Directory.Packages.props Updates Azure.Core/System.ClientModel versions and adds CleanRoom ARM package version.
.vscode/cspell.json Adds “cleanroom” spelling exceptions.
.github/CODEOWNERS Adds code owners for the new Managed Cleanroom tool directory.
Comments suppressed due to low confidence (10)

tools/Azure.Mcp.Tools.ManagedCleanroom/src/ManagedCleanroomSetup.cs:1

  • Only CollaborationsListCommand and CollaborationCreateCommand are registered and added to command groups, but the PR adds many additional commands (analytics/oidc/datasets/queries/invitations/auditevents and multiple collaboration ARM commands). As-is, those commands won't be resolvable from DI and/or won't appear in the command tree at runtime. Register the missing command types in ConfigureServices and add them under the appropriate CommandGroup hierarchy in RegisterCommands (e.g., analytics, oidc, datasets, queries, invitations, auditevents, plus the remaining collaboration subcommands).
    servers/Azure.Mcp.Server/src/Resources/consolidated-tools.json:1
  • This consolidated tool is marked readOnly: true and described as 'read-only details', but mappedToolList includes write operations like managedcleanroom_invitations_accept and managedcleanroom_oidc_set-issuer-url (and potentially others depending on intent). This mismatch can lead to tooling/agent policy violations (e.g., a 'read-only' tool performing state changes). Remove non-read-only commands from this grouping, or split into separate group(s) with correct metadata (readOnly=false/idempotent=false where appropriate).
    servers/Azure.Mcp.Server/src/Resources/consolidated-tools.json:1
  • This consolidated tool is marked readOnly: true and described as 'read-only details', but mappedToolList includes write operations like managedcleanroom_invitations_accept and managedcleanroom_oidc_set-issuer-url (and potentially others depending on intent). This mismatch can lead to tooling/agent policy violations (e.g., a 'read-only' tool performing state changes). Remove non-read-only commands from this grouping, or split into separate group(s) with correct metadata (readOnly=false/idempotent=false where appropriate).
    servers/Azure.Mcp.Server/src/Resources/consolidated-tools.json:1
  • This consolidated tool is marked readOnly: true and described as 'read-only details', but mappedToolList includes write operations like managedcleanroom_invitations_accept and managedcleanroom_oidc_set-issuer-url (and potentially others depending on intent). This mismatch can lead to tooling/agent policy violations (e.g., a 'read-only' tool performing state changes). Remove non-read-only commands from this grouping, or split into separate group(s) with correct metadata (readOnly=false/idempotent=false where appropriate).
    servers/Azure.Mcp.Server/src/Resources/consolidated-tools.json:1
  • This consolidated tool is marked readOnly: true and described as 'read-only details', but mappedToolList includes write operations like managedcleanroom_invitations_accept and managedcleanroom_oidc_set-issuer-url (and potentially others depending on intent). This mismatch can lead to tooling/agent policy violations (e.g., a 'read-only' tool performing state changes). Remove non-read-only commands from this grouping, or split into separate group(s) with correct metadata (readOnly=false/idempotent=false where appropriate).
    servers/Azure.Mcp.Server/src/Resources/consolidated-tools.json:1
  • This consolidated tool is marked readOnly: true and described as 'read-only details', but mappedToolList includes write operations like managedcleanroom_invitations_accept and managedcleanroom_oidc_set-issuer-url (and potentially others depending on intent). This mismatch can lead to tooling/agent policy violations (e.g., a 'read-only' tool performing state changes). Remove non-read-only commands from this grouping, or split into separate group(s) with correct metadata (readOnly=false/idempotent=false where appropriate).
    servers/Azure.Mcp.Server/src/Resources/consolidated-tools.json:1
  • managedcleanroom_collaboration_create is a create/provision operation, but this consolidated tool marks it as destructive: true and describes deletion/modification of existing resources. If the repository uses destructive to mean delete/irreversible mutation, this metadata is likely incorrect and can cause risk-based routing/policy decisions to behave incorrectly. Update the metadata to reflect the actual behavior (create/updates vs delete), aligning with the command’s own metadata.
    servers/Azure.Mcp.Server/src/Resources/consolidated-tools.json:1
  • managedcleanroom_collaboration_create is a create/provision operation, but this consolidated tool marks it as destructive: true and describes deletion/modification of existing resources. If the repository uses destructive to mean delete/irreversible mutation, this metadata is likely incorrect and can cause risk-based routing/policy decisions to behave incorrectly. Update the metadata to reflect the actual behavior (create/updates vs delete), aligning with the command’s own metadata.
    tools/Azure.Mcp.Tools.ManagedCleanroom/tests/test-resources.bicep:1
  • baseName defaults to resourceGroup().name but is constrained to @maxLength(24). Resource group names commonly exceed 24 chars, so deployments can fail when the default is used. Consider generating a compliant default (e.g., take(resourceGroup().name, 24) or a uniqueString(...)-based name) or removing/tightening constraints only where they’re actually required.
    tools/Azure.Mcp.Tools.ManagedCleanroom/src/Options/ManagedCleanroomOptionDescriptions.cs:1
  • DocumentId is a shared constant name but the description is specific to 'dataset document to publish'. This constant is used by multiple dataset commands (publish/get), and may be reused by non-publish contexts later; the wording will then be misleading. Consider making the description neutral (e.g., 'dataset document to retrieve/publish') or splitting into separate constants if you want context-specific help text.

Comment thread nuget.config Outdated
Comment thread servers/Azure.Mcp.Server/docs/azmcp-commands.md Outdated
Comment thread servers/Azure.Mcp.Server/changelog-entries/1780647747781.yaml Outdated
@ShreyaSangwa ShreyaSangwa requested a review from Copilot June 15, 2026 12:25
Copilot AI reviewed Jun 15, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 27 out of 27 changed files in this pull request and generated 6 comments.

Comment thread tools/Azure.Mcp.Tools.ManagedCleanroom/docs/architecture.md
Comment thread tools/Azure.Mcp.Tools.ManagedCleanroom/src/Services/ManagedCleanroomService.cs Outdated
Comment thread tools/Azure.Mcp.Tools.ManagedCleanroom/src/Services/ManagedCleanroomService.cs Outdated
Comment thread tools/Azure.Mcp.Tools.ManagedCleanroom/src/Options/Collaborations/CollaborationsListOptions.cs Outdated
Comment thread tools/Azure.Mcp.Tools.ManagedCleanroom/tests/test-resources.bicep Outdated
Comment thread tools/Azure.Mcp.Tools.ManagedCleanroom/src/Services/ManagedCleanroomService.cs Outdated
@ShreyaSangwa ShreyaSangwa requested a review from Copilot June 15, 2026 12:37
Copilot AI reviewed Jun 15, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 27 out of 27 changed files in this pull request and generated 5 comments.

Comment thread tools/Azure.Mcp.Tools.ManagedCleanroom/src/Services/ManagedCleanroomService.cs Outdated
Comment thread tools/Azure.Mcp.Tools.ManagedCleanroom/src/Services/ManagedCleanroomService.cs Outdated
Comment thread tools/Azure.Mcp.Tools.ManagedCleanroom/src/Services/ManagedCleanroomService.cs Outdated
Comment thread tools/Azure.Mcp.Tools.ManagedCleanroom/src/Services/ManagedCleanroomSerializerContext.cs Outdated
Comment thread tools/Azure.Mcp.Tools.ManagedCleanroom/src/Options/Collaboration/CollaborationCreateOptions.cs Outdated
@ShreyaSangwa ShreyaSangwa requested a review from Copilot June 15, 2026 12:47
Copilot AI reviewed Jun 15, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 26 out of 26 changed files in this pull request and generated 6 comments.

Comment thread tools/Azure.Mcp.Tools.ManagedCleanroom/docs/architecture.md Outdated
Comment thread tools/Azure.Mcp.Tools.ManagedCleanroom/docs/architecture.md
Comment thread tools/Azure.Mcp.Tools.ManagedCleanroom/src/Commands/ManagedCleanroomJsonContext.cs Outdated
Comment thread tools/Azure.Mcp.Tools.ManagedCleanroom/src/Services/ManagedCleanroomService.cs Outdated
Comment thread tools/Azure.Mcp.Tools.ManagedCleanroom/src/Services/ManagedCleanroomService.cs Outdated
Comment thread tools/Azure.Mcp.Tools.ManagedCleanroom/src/Services/ManagedCleanroomService.cs
@ShreyaSangwa ShreyaSangwa requested a review from Copilot June 15, 2026 13:00
Copilot AI reviewed Jun 15, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 26 out of 26 changed files in this pull request and generated 4 comments.

Comment thread tools/Azure.Mcp.Tools.ManagedCleanroom/src/Services/ManagedCleanroomService.cs Outdated
Comment thread tools/Azure.Mcp.Tools.ManagedCleanroom/src/Services/ManagedCleanroomService.cs
Comment thread tools/Azure.Mcp.Tools.ManagedCleanroom/tests/test-resources.bicep Outdated
Comment thread tools/Azure.Mcp.Tools.ManagedCleanroom/docs/architecture.md Outdated
@ShreyaSangwa ShreyaSangwa requested a review from Copilot June 15, 2026 13:08
yrcvohra
yrcvohra reviewed Jun 16, 2026
View reviewed changes
Comment thread Directory.Packages.props
yrcvohra
yrcvohra reviewed Jun 16, 2026
View reviewed changes
Comment thread tools/Azure.Mcp.Tools.ManagedCleanroom/src/ManagedCleanroomSetup.cs
yrcvohra
yrcvohra reviewed Jun 16, 2026
View reviewed changes
Comment thread tools/Azure.Mcp.Tools.ManagedCleanroom/src/ManagedCleanroomSetup.cs Outdated
alzimmermsft
alzimmermsft reviewed Jun 18, 2026
View reviewed changes
Comment thread ...Azure.Mcp.Tools.ManagedCleanroom/src/Commands/CollaborationArm/CollaborationCreateCommand.cs
- --subscription: Azure subscription
""",
Destructive = false,
Idempotent = true,

@alzimmermsft alzimmermsft Jun 18, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this a create or update type command? Generally, creation is idempotent as multiple calls will result in different responses as most services fail if the resource already exists.

Comment thread ...Azure.Mcp.Tools.ManagedCleanroom/src/Commands/CollaborationArm/CollaborationCreateCommand.cs Outdated
Comment thread ...Azure.Mcp.Tools.ManagedCleanroom/src/Commands/CollaborationArm/CollaborationCreateCommand.cs Outdated
Comment thread ...Azure.Mcp.Tools.ManagedCleanroom/src/Commands/CollaborationArm/CollaborationCreateCommand.cs Outdated
Comment thread ...Azure.Mcp.Tools.ManagedCleanroom/src/Commands/CollaborationArm/CollaborationCreateCommand.cs Outdated
Comment thread tools/Azure.Mcp.Tools.ManagedCleanroom/src/Options/ManagedCleanroomOptionDescriptions.cs
"The unique identifier (UUID) of the cleanroom collaboration.";

public const string TokenScope =
"Optional Microsoft Entra token scope for the cleanroom frontend API (for example, 'https://my-cleanroom.cloudapp.azure.net/.default'). Defaults to '<endpoint-origin>/.default'.";

@alzimmermsft alzimmermsft Jun 18, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this support custom scopes (ex, MyCustomEndpoint/.default)? If this something that could be inferred from Endpoint instead?

Comment thread tools/Azure.Mcp.Tools.ManagedCleanroom/src/Services/IManagedCleanroomService.cs
/// <summary>Result returned by <see cref="IManagedCleanroomServiceControlPlane.CreateCollaborationArmResourceAsync"/>.</summary>
/// <param name="Properties">ARM resource properties as a raw <see cref="System.Text.Json.JsonElement"/>.</param>
/// <param name="Message">Human-readable summary of the provisioning outcome including elapsed time.</param>
public sealed record CollaborationCreateResult(System.Text.Json.JsonElement Properties, string Message);

@alzimmermsft alzimmermsft Jun 18, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I recommend moving this into its own class under /src/Models to follow standard designs.

Comment thread tools/Azure.Mcp.Tools.ManagedCleanroom/src/Services/IManagedCleanroomService.cs
/// Control-plane (ARM) operations for managing Cleanroom collaboration resources.
/// Authentication uses the standard Azure Resource Manager credential.
/// </summary>
public interface IManagedCleanroomServiceControlPlane

@alzimmermsft alzimmermsft Jun 18, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I recommend splitting these two interfaces into separate files named after the interface, will make it easier to navigate through this code.

Comment thread tools/Azure.Mcp.Tools.ManagedCleanroom/src/Services/ManagedCleanroomService.cs
namespace Azure.Mcp.Tools.ManagedCleanroom.Services;

public class ManagedCleanroomService(ISubscriptionService subscriptionService, ITenantService tenantService, IHttpClientFactory httpClientFactory)
: BaseAzureResourceService(subscriptionService, tenantService), IManagedCleanroomServiceDataPlane, IManagedCleanroomServiceControlPlane

@alzimmermsft alzimmermsft Jun 18, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the service implementation is going to implement both interfaces, just make it one bigger interface. Doesn't really give much benefit having two different ones in this case when the only implementation implements both.

Comment thread tools/Azure.Mcp.Tools.ManagedCleanroom/src/Services/ManagedCleanroomService.cs
Comment on lines +115 to +122
if (!Uri.TryCreate(endpoint, UriKind.Absolute, out var endpointUri))
{
throw new ArgumentException($"Endpoint '{endpoint}' is not a valid absolute URI.", nameof(endpoint));
}

if (endpointUri.Scheme != Uri.UriSchemeHttps)
{
throw new ArgumentException("Endpoint must use HTTPS.", nameof(endpoint));

@alzimmermsft alzimmermsft Jun 18, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I recommend following what was done here: https://github.com/microsoft/mcp/pull/2895/changes

To validate the URL

@ShreyaSangwa

ShreyaSangwa commented Jun 25, 2026

Copy link
Copy Markdown
Author

@microsoft-github-policy-service agree company="Microsoft"

@conniey conniey mentioned this pull request Jun 25, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alzimmermsft alzimmermsft alzimmermsft left review comments
@yrcvohra yrcvohra yrcvohra left review comments
Copilot code review Copilot Copilot left review comments
@hallipr hallipr Awaiting requested review from hallipr hallipr is a code owner automatically assigned from microsoft/azure-mcp
@joshfree joshfree Awaiting requested review from joshfree joshfree is a code owner automatically assigned from microsoft/azure-mcp
@jongio jongio Awaiting requested review from jongio jongio is a code owner automatically assigned from microsoft/azure-mcp
@g2vinay g2vinay Awaiting requested review from g2vinay g2vinay is a code owner automatically assigned from microsoft/azure-mcp
@KarishmaGhiya KarishmaGhiya Awaiting requested review from KarishmaGhiya KarishmaGhiya is a code owner automatically assigned from microsoft/azure-mcp
@tmeschter tmeschter Awaiting requested review from tmeschter tmeschter is a code owner automatically assigned from microsoft/azure-mcp
@srnagar srnagar Awaiting requested review from srnagar srnagar is a code owner automatically assigned from microsoft/azure-mcp
@wbreza wbreza Awaiting requested review from wbreza wbreza is a code owner
@ankiga-MSFT ankiga-MSFT Awaiting requested review from ankiga-MSFT ankiga-MSFT is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

community contribution customer-reported

Projects

Azure MCP Server
Status: Untriaged

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ShreyaSangwa @alzimmermsft @yrcvohra