Fix error when hovering over invalid :nth-child() selector - #5455
Draft
Martin Aeschlimann (aeschli) with Copilot wants to merge 3 commits into
Draft
Fix error when hovering over invalid :nth-child() selector#5455Martin Aeschlimann (aeschli) with Copilot wants to merge 3 commits into
:nth-child() selector#5455Martin Aeschlimann (aeschli) with Copilot wants to merge 3 commits into
Conversation
2 tasks
Co-authored-by: aeschli <6461412+aeschli@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix error when hovering over invalid
Fix error when hovering over invalid Aug 18, 2026
:nth-child instruction:nth-child() selector
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hovering an invalid
:nth-child()selector in a CSS model threw out of the worker and reached the editor's error handling:Root cause is in
vscode-css-languageservicespecificity calculation, which readschildElements[1].getText()for:nth-child(...)without checking that a second child exists — still present in 6.3.10 and upstreammain, so it can't be resolved by a version bump.Changes
src/languages/features/css/cssWorker.ts:doHovercatches errors from the language service and returnsnull, so an unparseable selector yields no hover instead of an unhandled rejection.src/languages/features/css/cssWorker.test.ts: regression test covering:nth-child()(no hover, no throw) andli:nth-child(2n of .important)(hover still produced).package.json: test glob widened fromsrc/languages/definitions/*/*.test.tstosrc/languages/**/*.test.tsso feature-level tests run.Notes for reviewers
The catch is deliberately scoped to hover only; other worker entry points are untouched. If the upstream parser bug is fixed and released, this guard becomes redundant but harmless.
:nth-childinstruction #5430