You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Unix / SQL Server 2022: Python 3.12.3, x86_64, SQL 16.0.4295.3; 5 paired comparisons and 1 warmup.
Unix / SQL Server 2025: Python 3.12.3, x86_64, SQL 17.0.5005.3; 5 paired comparisons and 1 warmup.
A consistent change requires more than 20% median paired movement, at least 1 ms between the median runtimes, and at least 80% of pairs exceeding the relative threshold in the same direction. A slowdown without enough pair agreement is reported as inconsistent.
The displayed change is the median of paired before-and-after ratios. It is not recalculated from the two displayed median runtimes.
Both revisions use profiling-enabled builds on the same agent and database, with alternating order and discarded warmups. Results are diagnostic and do not represent production-wheel latency.
Raw samples and logs are attached to the ADO run as profiler-* artifacts.
The reason will be displayed to describe this comment to others. Learn more.
🔵 Needs a closer look
The release depends on unpublished mssql-python-odbc 18.6.2.2, and several release-note claims need correction.
0 open findings
Previously missed (3)
In code that hasn't changed since last review
Correct release-wheel attribution to include PR #838
PyPI_Description.md:42
This attributes both validation and release-wheel support to #817, but #817 added validation while #838 is the merged change that adds the CPython 3.15 release-wheel stages. Include #838 so the release note accurately traces the wheel claim.
Reframe provider selection as a 1.16 dependency change
PyPI_Description.md:45
Provider selection already shipped in v1.15.0: that tag exposes native_provider/get_native_provider_info(), documents the opt-in provider, and its release commit lists #730. Reframe this entry around the 1.16 change—the exact mssql-python-rs dependency now installs the existing optional provider—so the “what's new” section does not present prior-release functionality as new.
Remove unsupported performance claim without indexing benchmarks
PyPI_Description.md:52
The linked PR provides no indexing-specific benchmark, and its advisory performance run reports no affected phase or call-count change, so “Faster” is not supported by the available measurements. Use mechanism-only wording unless a focused positional-index benchmark demonstrates the claim.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AB#49327
Summary
Prepares mssql-python 1.16.0 for release.
Enhancements
Row._mapping.mssql-python-rs0.3.0 wheels instead of embedding Rust runtime files.fetchval()logging.Bug Fixes
setencoding()requests cannot be applied.mssql_py_core.Version
mssql_python.__version__andsetup.pyfrom 1.15.0 to 1.16.0.