Centralize the tempfile dev-dependency in workspace deps#516
Open
MGudgin wants to merge 3 commits into
Open
Conversation
This PR lifts the duplicated tempfile dev-dependency into the workspace so crates inherit a single pinned version instead of each pinning tempfile = "3" independently. Details * Add tempfile to [workspace.dependencies] in src/Cargo.toml. * Switch appcontainer/common, wslc/common, and wxc_host_prep from tempfile = "3" to tempfile.workspace = true. Tests * cargo metadata resolves the workspace cleanly. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
MGudgin
force-pushed
the
user/gudge/tempfile-workspace-dep
branch
from
94cece1 to
a5c98d5
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Centralizes the tempfile dev-dependency version at the Rust workspace level so individual crates can inherit a single pinned version, reducing duplication and dependency drift risk across the workspace.
Changes:
- Add
tempfile = "3"tosrc/Cargo.toml[workspace.dependencies]. - Switch multiple crates’
[dev-dependencies]fromtempfile = "3"totempfile.workspace = true.
Show a summary per file
| File | Description |
|---|---|
| src/Cargo.toml | Adds tempfile to workspace dependencies for centralized versioning. |
| src/backends/appcontainer/common/Cargo.toml | Inherits tempfile version from the workspace for dev-deps. |
| src/backends/wslc/common/Cargo.toml | Inherits tempfile version from the workspace for dev-deps. |
| src/host/wxc_host_prep/Cargo.toml | Inherits tempfile version from the workspace for dev-deps. |
Copilot's findings
- Files reviewed: 4/4 changed files
- Comments generated: 2
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Member
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR lifts the duplicated tempfile dev-dependency into the workspace so crates inherit a single pinned version instead of each pinning
tempfile = "3"independently.Details
tempfileto[workspace.dependencies]insrc/Cargo.toml.appcontainer/common,wslc/common, andwxc_host_prepfromtempfile = "3"totempfile.workspace = true.Tests
cargo metadataresolves the workspace cleanly.