chore: declare MIT license metadata for all crates#538
Open
caarlos0 wants to merge 1 commit into
Open
Conversation
Add `license = "MIT"` to the workspace package and `license.workspace = true` to every member crate so each crate carries explicit license metadata. The workspace-excluded `mxc_fuzz` crate gets a direct `license = "MIT"` since it cannot inherit from `[workspace.package]`. Ports the crate-license metadata from microsoft/mxc PR microsoft#524. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Adds explicit MIT license metadata across the Rust workspace so each crate’s published metadata is consistent and centrally managed via [workspace.package] inheritance.
Changes:
- Set
license = "MIT"insrc/Cargo.tomlunder[workspace.package]. - Added
license.workspace = trueto all workspace member crates to inherit the workspace license. - Added a direct
license = "MIT"to the excludedsrc/testing/fuzzcrate (mxc_fuzz) since it cannot inherit from the workspace.
Show a summary per file
| File | Description |
|---|---|
| src/Cargo.toml | Declares workspace-wide license = "MIT" for inheritance. |
| src/backends/appcontainer/common/Cargo.toml | Inherits workspace license metadata. |
| src/backends/bubblewrap/common/Cargo.toml | Inherits workspace license metadata. |
| src/backends/hyperlight/common/Cargo.toml | Inherits workspace license metadata. |
| src/backends/isolation_session/bindings/Cargo.toml | Inherits workspace license metadata. |
| src/backends/isolation_session/common/Cargo.toml | Inherits workspace license metadata. |
| src/backends/lxc/common/Cargo.toml | Inherits workspace license metadata. |
| src/backends/nanvix/binaries/Cargo.toml | Inherits workspace license metadata. |
| src/backends/nanvix/build_common/Cargo.toml | Inherits workspace license metadata. |
| src/backends/nanvix/common/Cargo.toml | Inherits workspace license metadata. |
| src/backends/nanvix/runner/Cargo.toml | Inherits workspace license metadata. |
| src/backends/seatbelt/common/Cargo.toml | Inherits workspace license metadata. |
| src/backends/windows_sandbox/common/Cargo.toml | Inherits workspace license metadata. |
| src/backends/windows_sandbox/daemon/Cargo.toml | Inherits workspace license metadata. |
| src/backends/windows_sandbox/guest/Cargo.toml | Inherits workspace license metadata. |
| src/backends/wslc/common/Cargo.toml | Inherits workspace license metadata. |
| src/core/generated/base_container_specification/Cargo.toml | Inherits workspace license metadata. |
| src/core/lxc/Cargo.toml | Inherits workspace license metadata. |
| src/core/mxc_build_common/Cargo.toml | Inherits workspace license metadata. |
| src/core/mxc_darwin/Cargo.toml | Inherits workspace license metadata. |
| src/core/mxc_pty/Cargo.toml | Inherits workspace license metadata. |
| src/core/wxc/Cargo.toml | Inherits workspace license metadata. |
| src/core/wxc_common/Cargo.toml | Inherits workspace license metadata. |
| src/host/wxc_host_prep/Cargo.toml | Inherits workspace license metadata. |
| src/host/wxc_winhttp_proxy_shim/Cargo.toml | Inherits workspace license metadata. |
| src/testing/fuzz/Cargo.toml | Declares direct license = "MIT" for excluded fuzz crate. |
| src/testing/linux_test_proxy/Cargo.toml | Inherits workspace license metadata. |
| src/testing/wxc_e2e_tests/Cargo.toml | Inherits workspace license metadata. |
| src/testing/wxc_test_driver/Cargo.toml | Inherits workspace license metadata. |
| src/testing/wxc_test_proxy/Cargo.toml | Inherits workspace license metadata. |
| src/testing/wxc_ui_probe/Cargo.toml | Inherits workspace license metadata. |
| src/tools/mxc_diagnostic_console/Cargo.toml | Inherits workspace license metadata. |
Copilot's findings
- Files reviewed: 31/32 changed files
- Comments generated: 0
MGudgin
approved these changes
Jun 19, 2026
MGudgin
approved these changes
Jun 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📖 Description
Adds explicit license metadata to every crate in the Rust workspace.
src/Cargo.toml— setslicense = "MIT"on[workspace.package].license.workspace = trueso they inherit the workspace license.src/testing/fuzz/Cargo.toml(mxc_fuzz) — gets a directlicense = "MIT"because it isexcluded from the workspace and cannot inherit from[workspace.package].This is a pure metadata change:
licenselines only, no functional or build-behavior changes. Each crate's existing line endings (LF, and CRLF forwxc_common,base_container_specification, andmxc_diagnostic_console) were preserved.🔗 References
Extracts the crate-license metadata changes from #524 into a standalone PR.
🔍 Validation
cargo metadata --no-depsresolveslicense = "MIT"for all 30 workspace members; none missing.Cargo.tomlfiles parse as valid TOML.git diffconfirms 32 insertions, 0 deletions — every added line is alicensedeclaration.✅ Checklist
📋 Issue Type
Microsoft Reviewers: Open in CodeFlow