Fix per-thread throughput when EStats are disabled - #32
Closed
Muhammad Labeeb Aryan bin Mohd Lokman (Labeeb2339) wants to merge 1 commit into
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #24
Cause
In v5.40, worker start/end timestamps were captured only inside the
tcp_rowblock.tcp_rowis created only for successful TCP EStats setup, so normal runs without-esleft per-thread worker time at zero even though per-thread byte counters and totals were populated.Change
tcp_row.Validation
tests/test_per_thread_throughput.ps1, a dependency-free regression guard for both worker paths, and wired it into the Windows build workflow.UndockedSourceLink=false,UndockedUseDriverToolset=false, andSpectreMitigation=falsebecause those local components are unavailable).-esin synchronous and asynchronous modes; both reported non-zero per-thread time/throughput and non-zero totals.Related upstream work exists in #31; this change keeps the fix scoped to the issue and preserves existing EStats behavior.