[WebGPU] Optimize MatMulNBits wide-tile shader#29611
Open
daijh wants to merge 1 commit into
Open
Conversation
Contributor
Author
|
@qjia7 @hariharans29 PTAL |
Contributor
Please check #29599, I think using f32 accumulators is the right direction. Could you split the refactoring changes into a separate PR? That would make it much easier to review and focus on the optimization work. |
- Store the A workgroup tile as [kTileM][KAVecSizeForBlock32/2][2] pairs of vecs so the two vecs consumed per dequantized weight column are read in one access. - Accumulate directly in output_element_t (e.g., f16 for f16 models) instead of hardcoding to f32.
daijh
changed the title
Contributor
Author
|
Let's leave this refactoring for a follow-up PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Intel Panther Lake
[1] https://huggingface.co/onnx-community/gpt-oss-20b-ONNX
[2] https://huggingface.co/onnx-community/Phi-4-mini-instruct-ONNX
Motivation and Context
See above.