Fix memory leak in GetOverridableInitializerNames()#29616
Draft
skottmckay with Copilot wants to merge 2 commits into
Draft
Fix memory leak in GetOverridableInitializerNames()#29616skottmckay with Copilot wants to merge 2 commits into
skottmckay with Copilot wants to merge 2 commits into
Conversation
Add missing allocator.Free(name) after copying the name into the string vector, matching the pattern used in GetInputNames() and GetOutputNames(). Fixes #29603
Copilot
AI
changed the title
[WIP] Fix C++ memory leak in GetOverridableInitializerNames
Fix memory leak in GetOverridableInitializerNames()
Jul 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
ConstSessionImpl::GetOverridableInitializerNames()was leaking the allocator-ownedchar*buffer after copying it intostd::string, unlike the sibling functionsGetInputNames()andGetOutputNames()which correctly callallocator.Free(name).Fix: Add the missing
allocator.Free(name)afteremplace_back:Motivation and Context
Every call to
GetOverridableInitializerNames()on a model with overridable initializers leaked one heap allocation per initializer. Reproducible by calling the function repeatedly and observing monotonically increasing resident memory.