Skip to content

fix(android): include the from point in input.swipe #42353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Ayaan Gazali (ayaangazali) wants to merge 1 commit into from
Closed

fix(android): include the from point in input.swipe #42353

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/playwright-core/src/client/android.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -335,7 +335,8 @@ export class AndroidInput implements api.AndroidInput {
}

async swipe(from: types.Point, segments: types.Point[], steps: number) {
await this._device._channel.inputSwipe({ segments, steps }, kNoTimeout);
// `from` is the first point of the gesture, `segments` are the points following it.
await this._device._channel.inputSwipe({ segments: [from, ...segments], steps }, kNoTimeout);
}

async drag(from: types.Point, to: types.Point, steps: number) {
Expand Down