Skip to content

feat(webkit): roll to r2359 - #42493

Merged
Dmitry Gozman (dgozman) merged 1 commit into
mainfrom
roll-into-pw-webkit/2359
Sep 2, 2026
Merged

feat(webkit): roll to r2359#42493
Dmitry Gozman (dgozman) merged 1 commit into
mainfrom
roll-into-pw-webkit/2359

Conversation

@microsoft-playwright-automation

Copy link
Copy Markdown
Contributor

Browser build: https://github.com/microsoft/playwright-browsers/commit/e32b4c0e4cb8e61824ad6615b7c402e3b9597642. Build has full platform coverage - check that all tests pass there.

@github-actions

github-actions Bot commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

Test results for "tests 1"

3 flaky ⚠️ [firefox-library] › library/browsercontext-cookies-third-party.spec.ts:257 › third party 'Partitioned;' cookies `@firefox-ubuntu-22.04-node20`
⚠️ [firefox-library] › library/browsercontext-cookies-third-party.spec.ts:470 › top level 'Partitioned;' cookie and same origin iframe `@firefox-ubuntu-22.04-node20`
⚠️ [firefox-page] › page/page-event-request.spec.ts:181 › should return response body when Cross-Origin-Opener-Policy is set `@firefox-ubuntu-22.04-node20`

51295 passed, 1241 skipped


Merge workflow run.

@github-actions

github-actions Bot commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

Test results for "MCP"

1 failed
❌ [firefox] › mcp/cli-drag.spec.ts:53 › drop files and data onto an element @mcp-windows-latest-firefox

8307 passed, 1377 skipped


Merge workflow run.

@github-actions

github-actions Bot commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

Hi, I'm the Playwright bot and I took a first look at the CI failures here.

🟢 CI is clear — the one real failure is a pre-existing Windows/Firefox flake

This PR only bumps the WebKit revision (browsers.json, 23582359), so it can't touch Firefox on Windows — and that's the only failing test.

Details

Overall: the "tests 1" report has no real failures (3 flaky, all Firefox, passed on retry). The "MCP" report has a single failure that reproduces on main and unrelated PRs, well before this roll. Nothing points at the WebKit bump.

Pre-existing flake / infra

  • [firefox] › mcp/cli-drag.spec.ts:53 › drop files and data onto an element on @mcp-windows-latest-firefox — pre-existing flake, confined to the Windows Firefox bot. In the CI results DB this exact test failed on mcp-windows-latest-firefox on main and on an unrelated PR long before this PR existed: run 31225630256 (main, 2026-08-07), run 31523555793 (main, 2026-08-11), run 32060840420 (PR fix(chromium): dispose worker sessions when their frame session is disposed #42282 fix-42278, 2026-08-17), and run 32155212762 (main, 2026-08-18). It passed on the Ubuntu and macOS Firefox bots for this PR's own run. A WebKit revision bump can't affect Firefox on Windows.

Flaky (already retried green in this report)

  • [firefox-library] › library/browsercontext-cookies-third-party.spec.ts:257 › third party 'Partitioned;' cookies
  • [firefox-library] › library/browsercontext-cookies-third-party.spec.ts:470 › top level 'Partitioned;' cookie and same origin iframe
  • [firefox-page] › page/page-event-request.spec.ts:181 › should return response body when Cross-Origin-Opener-Policy is set

All Firefox-only, all passed on retry — again untouched by a WebKit roll.

Triaged by the Playwright bot - agent run

@github-actions

github-actions Bot commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

Test results for "tests 2"

12 failed
❌ [chromium-library] › library/browsertype-connect.spec.ts:1165 › should filter local paths from unsafe launch options @tracing-chromium
❌ [chromium-library] › library/browsertype-connect.spec.ts:1165 › should filter local paths from unsafe launch options @msedge-dev-windows-latest
❌ [chromium-page] › page/page-route.spec.ts:277 › should work with custom referer headers @msedge-dev-windows-latest
❌ [chromium-page] › page/page-set-extra-http-headers.spec.ts:65 › should not duplicate referer header @msedge-dev-windows-latest
❌ [chromium-library] › library/browsertype-connect.spec.ts:1165 › should filter local paths from unsafe launch options @chrome-ubuntu-22.04
❌ [chromium-library] › library/browsertype-connect.spec.ts:1165 › should filter local paths from unsafe launch options @msedge-windows-latest
❌ [chromium-library] › library/browsertype-connect.spec.ts:1165 › should filter local paths from unsafe launch options @chrome-windows-latest
❌ [chromium-library] › library/browsertype-connect.spec.ts:1165 › should filter local paths from unsafe launch options @chrome-beta-ubuntu-22.04
❌ [chromium-library] › library/browsertype-connect.spec.ts:1165 › should filter local paths from unsafe launch options @chrome-macos-latest
❌ [firefox-library] › library/browsertype-connect.spec.ts:1165 › should filter local paths from unsafe launch options @tracing-firefox
❌ [webkit-library] › library/browsertype-connect.spec.ts:1165 › should filter local paths from unsafe launch options @tracing-webkit
❌ [webkit-page] › page/page-leaks.spec.ts:136 › expect should not leak @webkit-macos-15-xlarge

26 flaky ⚠️ [chromium-library] › library/chromium/chromium.spec.ts:179 › serviceWorker(), and fromServiceWorker() work `@chromium-macos-15-large`
⚠️ [chromium-library] › library/chromium/chromium.spec.ts:213 › should intercept service worker requests (main and within) `@chromium-macos-14-xlarge`
⚠️ [chromium-library] › library/chromium/oopif.spec.ts:179 › should take screenshot `@chromium-macos-14-xlarge`
⚠️ [chromium-library] › library/trace-viewer.spec.ts:1695 › should highlight locator in iframe while typing `@chromium-macos-15-xlarge`
⚠️ [chromium-library] › library/chromium/chromium.spec.ts:179 › serviceWorker(), and fromServiceWorker() work `@chrome-beta-ubuntu-22.04`
⚠️ [chromium-library] › library/chromium/chromium.spec.ts:373 › should produce network events, routing, and annotations for Service Worker `@chrome-beta-ubuntu-22.04`
⚠️ [chromium-library] › library/chromium/chromium.spec.ts:436 › should produce network events, routing, and annotations for Service Worker (advanced) `@chrome-beta-ubuntu-22.04`
⚠️ [chromium-library] › library/chromium/chromium.spec.ts:213 › should intercept service worker requests (main and within) `@chrome-macos-latest`
⚠️ [chromium-library] › library/selector-generator.spec.ts:165 › selector generator › should try to improve text by shortening `@chrome-macos-latest`
⚠️ [firefox-library] › library/browsercontext-cookies-third-party.spec.ts:257 › third party 'Partitioned;' cookies `@tracing-firefox`
⚠️ [firefox-library] › library/browsercontext-cookies-third-party.spec.ts:470 › top level 'Partitioned;' cookie and same origin iframe `@tracing-firefox`
⚠️ [firefox-page] › page/page-event-request.spec.ts:181 › should return response body when Cross-Origin-Opener-Policy is set `@tracing-firefox`
⚠️ [firefox-library] › library/browsercontext-cookies-third-party.spec.ts:257 › third party 'Partitioned;' cookies `@firefox-macos-15-large`
⚠️ [firefox-library] › library/browsercontext-cookies-third-party.spec.ts:470 › top level 'Partitioned;' cookie and same origin iframe `@firefox-macos-15-large`
⚠️ [firefox-library] › library/browsercontext-cookies-third-party.spec.ts:257 › third party 'Partitioned;' cookies `@firefox-windows-latest`
⚠️ [firefox-library] › library/browsercontext-cookies-third-party.spec.ts:470 › top level 'Partitioned;' cookie and same origin iframe `@firefox-windows-latest`
⚠️ [firefox-library] › library/browsercontext-basic.spec.ts:163 › should propagate default viewport to the page `@firefox-macos-15-xlarge`
⚠️ [firefox-library] › library/browsercontext-cookies-third-party.spec.ts:257 › third party 'Partitioned;' cookies `@firefox-macos-15-xlarge`
⚠️ [firefox-library] › library/browsercontext-cookies-third-party.spec.ts:470 › top level 'Partitioned;' cookie and same origin iframe `@firefox-macos-15-xlarge`
⚠️ [firefox-library] › library/browsercontext-viewport.spec.ts:132 › should set both screen and viewport options `@firefox-macos-15-xlarge`
⚠️ [firefox-library] › library/trace-viewer.spec.ts:1915 › should not leak recorders `@firefox-macos-15-xlarge`
⚠️ [firefox-page] › page/page-emulate-media.spec.ts:144 › should keep reduced motion and color emulation after reload `@firefox-macos-15-xlarge`
⚠️ [webkit-library] › library/inspector/cli-codegen-python-async.spec.ts:24 › should print the correct imports and context options `@webkit-windows-latest`
⚠️ [webkit-library] › library/tracing.spec.ts:533 › should produce screencast frames fit `@webkit-macos-15-xlarge`
⚠️ [webkit-library] › library/video.spec.ts:113 › screencast › should capture static page `@webkit-macos-15-xlarge`
⚠️ [webkit-library] › library/browsertype-connect.spec.ts:807 › launchServer › should upload a folder `@webkit-macos-15-large`

110521 passed, 4723 skipped


Merge workflow run.

@github-actions

github-actions Bot commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

Hi, I'm the Playwright bot and I took a second look — a new "tests 2" report landed after my first pass, and it changes the verdict.

🔴 One failure looks caused by this WebKit roll

page/page-leaks.spec.ts:136 leaks under WebKit r2359 on webkit-macos-15-xlarge — a reproducible regression, not a flake.

Details

Overall: the earlier "tests 1" and "MCP" reports were clean (Firefox-only flakes + a pre-existing Windows/Firefox flake). The new "tests 2" report has 12 failures. Eleven of them are one cross-browser test that also fails on main, so a WebKit bump can't be the cause. The twelfth is WebKit-only and reproduces only on this roll — that's the real one.

Caused by this PR

  • [webkit-page] › page/page-leaks.spec.ts:136 › expect should not leak on @webkit-macos-15-xlarge — in the CI results DB this test has run 1865 times since 2026-07-21 and failed exactly once: here, on this PR (run 33550220867). It passed 301 prior times on this exact bot. It failed all four attempts with the same assertion — expect(objectCount).toBeLessThan(25), Received: 58 — so it's a consistent object-retention regression, not a timeout blip. A leak test that only regresses on a WebKit binary bump points squarely at r2359. Worth confirming against the browser build before merging.

Pre-existing flake / infra (not this PR)

  • library/browsertype-connect.spec.ts:1165 › should filter local paths from unsafe launch options — failed across chromium, firefox, webkit, msedge, and chrome bots in this report, and in the DB it also fails on main (pr_number null, run started 2026-09-01 19:32). A WebKit-only revision bump cannot break Chromium/Firefox/MSEdge, and it's broken off this PR's branch anyway — so this is a separate, cross-browser breakage landing around the same time, not caused by this roll.

Flaky (rescued on retry, ignore)

  • 26 tests passed on retry — Firefox cookie/viewport tests, Chromium service-worker tests, and four WebKit tests (tracing.spec.ts:533, video.spec.ts:113, cli-codegen-python-async.spec.ts:24, browsertype-connect.spec.ts:807). All flipped green within the run.

Triaged by the Playwright bot - agent run

@dgozman
Dmitry Gozman (dgozman) merged commit 2dec18d into main Sep 2, 2026
64 of 75 checks passed
@dgozman
Dmitry Gozman (dgozman) deleted the roll-into-pw-webkit/2359 branch September 2, 2026 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant