fix(typespec-vscode): ensure operation telemetry result is never undefined

[RodgeFu]

Problem

The start-extension telemetry event (and any other operation whose callback returned void) was always being sent with result="undefined" and routed through sendTelemetryErrorEvent, so it was incorrectly classified as an error event in App Insights.

Root cause: the generic type parameter T on doOperationWithTelemetry was unconstrained, so the auto-detect block (if (result) ...) could not derive a ResultCode from a callback returning void or undefined. The activate callback in extension.ts returned Promise<void>, hitting this case on every successful activation.

Fix

• Constrain the generic in doOperationWithTelemetry to T extends ResultCode | Result<unknown>. Now callers must return one of those, and the result is always derivable.
• Update activate to return ResultCode.Success so it conforms to the new contract.
• Drop the if (result) guard around the auto-detect block. If a future caller manages to bypass the type system and return a falsy value, the event will still be sent with result="undefined" so the bug is visible rather than silent.

Verification

Walked through all 9 doOperationWithTelemetry callsites against their callback return types - every one now returns a ResultCode or Result<...>. TypeScript build is clean.

[pkg-pr-new]

Open in StackBlitz

npm i https://pkg.pr.new/typespec-vscode@10527

commit: ddd778b

[github-actions]

All changed packages have been documented.

• ✅ typespec-vscode

Show changes

typespec-vscode - fix ✏️

Ensure operation telemetry events always carry a valid result value. Previously the start-extension event (and any other operation whose callback returned void) was sent with result="undefined" and classified as an error event. The doOperationWithTelemetry callback is now constrained to return ResultCode | Result<...>, so the result is always derived from the operation's return value.

[azure-sdk]

You can try these changes here

🛝 Playground	🌐 Website	🛝 VSCode Extension