Honor exact C# names over back-compat naming - #11663
Draft
Jorge Rangel (jorgerangel-msft) with Copilot wants to merge 6 commits into
Draft
Honor exact C# names over back-compat naming#11663Jorge Rangel (jorgerangel-msft) with Copilot wants to merge 6 commits into
Jorge Rangel (jorgerangel-msft) with Copilot wants to merge 6 commits into
Conversation
|
Azure Pipelines: Successfully started running 1 pipeline(s). 1 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Copilot started work on behalf of
Jorge Rangel (jorgerangel-msft)
August 13, 2026 20:40
View session
Co-authored-by: jorgerangel-msft <102122018+jorgerangel-msft@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Consider having exact override back compat naming
Honor exact C# names over back-compat naming
Aug 13, 2026
Copilot started work on behalf of
Jorge Rangel (jorgerangel-msft)
August 19, 2026 16:49
View session
commit: |
Co-authored-by: jorgerangel-msft <102122018+jorgerangel-msft@users.noreply.github.com>
Copilot started reviewing on behalf of
Jorge Rangel (jorgerangel-msft)
August 19, 2026 17:34
View session
Contributor
There was a problem hiding this comment.
Pull request overview
Ensures exact C# parameter names take precedence over names restored from previous contracts.
Changes:
- Skips back-compat renaming for exact service and property-derived parameters.
- Prevents duplicate model factory compatibility overloads.
- Adds regression tests for RestClient and model factory paths.
Reviewed changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
.../test/Providers/TypeProviderTests.cs |
Tests exact-name precedence. |
.../BuildMethodsForBackCompatibilityExactNameTakesPrecedence(Last)/TestClient.cs |
Defines the prior contract fixture. |
.../BuildMethodsForBackCompatibilityExactNameTakesPrecedence.cs |
Captures expected exact-name output. |
.../BackCompatibility_ExactPropertyNameTakesPrecedence(Last)/SampleNamespaceModelFactory.cs |
Defines the prior model factory contract. |
.../BackCompatibility_ExactPropertyNameTakesPrecedence.cs |
Captures expected model factory output. |
.../ModelFactoryProviderTests.cs |
Tests mixed exact and restored property names. |
.../Utilities/BackCompatHelper.cs |
Excludes exact parameters from name restoration. |
.../Providers/ParameterProvider.cs |
Exposes exact-name metadata for parameters. |
.../Providers/ModelFactoryProvider.cs |
Treats exact-name differences as compatible. |
.../ExactParameterNameTakesPrecedenceOverLastContractView(Last)/TestClient.cs |
Defines the prior RestClient contract. |
.../ExactParameterNameTakesPrecedenceOverLastContractView.cs |
Captures expected RestClient output. |
.../RestClientProviderTests.cs |
Adds RestClient naming regression coverage. |
.../RestClientProvider.cs |
Prevents last-contract names overriding exact names. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Copilot started work on behalf of
Jorge Rangel (jorgerangel-msft)
August 19, 2026 17:43
View session
Co-authored-by: jorgerangel-msft <102122018+jorgerangel-msft@users.noreply.github.com>
Copilot started work on behalf of
Jorge Rangel (jorgerangel-msft)
August 19, 2026 18:09
View session
Jorge Rangel (jorgerangel-msft)
left a comment
Contributor
There was a problem hiding this comment.
Copilot pull latest from main and address the merge conflicts
Copilot started work on behalf of
Jorge Rangel (jorgerangel-msft)
August 21, 2026 16:05
View session
Copilot started reviewing on behalf of
Jorge Rangel (jorgerangel-msft)
August 21, 2026 16:05
View session
Co-authored-by: jorgerangel-msft <102122018+jorgerangel-msft@users.noreply.github.com>
Co-authored-by: jorgerangel-msft <102122018+jorgerangel-msft@users.noreply.github.com>
Contributor
Author
Merged the latest |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Names explicitly configured with
exactcould be replaced by names restored from the previous contract. This made advanced client naming overrides ineffective when back compatibility was enabled.Naming precedence
Model factories
Coverage
The generated C# parameter remains
api_key, even when the previous contract used another name.