fix: warn when markdown link path casing doesn't match actual file on…#227
Open
vibhumeh wants to merge 1 commit into
Open
fix: warn when markdown link path casing doesn't match actual file on…#227vibhumeh wants to merge 1 commit into
vibhumeh wants to merge 1 commit into
Conversation
Author
|
@microsoft-github-policy-service agree |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #106
On case insensitive filesystems (macOS and Windows), workspace.stat()
succeeds even when path casing doesn't match the actual file on disk.
This means a link like text silently resolves
even when the real file is docs/whitepaper.pdf, then breaks when
deployed to a case-sensitive system like GitHub (Linux).
Changes:
link.file-path-casing-mismatchdiagnostic codevalidateFileLinksMarkdownCaseSensitiveoption to DiagnosticOptions(defaults to true, set to false to opt out)
verifies the exact basename casing matches
Note: this behavior cannot be fully unit tested with InMemoryWorkspace
since it simulates a case-sensitive filesystem. The casing check only
triggers on macOS/Windows where workspace.stat() succeeds despite path
casing mismatches, as documented in the VS Code API.