fix: dispose orphaned progress notifications on language server shutdown - #26130
Open
MOHAMMED WASIM KHAN (wasim-builds) wants to merge 1 commit into
Open
Conversation
Fixes microsoft#16750 Ensures that any pending progress UI notifications are resolved when the Language Server progress tracking is disposed, preventing orphaned progress bars from hanging indefinitely in the status bar if the server restarts or crashes.
Member
|
🔒 Automated review in progress — Bill Schnurr (@bschnurr) is auto-reviewing this PR. |
Member
|
Verification: The relevant tests could not be fully run in the isolated environment; this review is not fully verified. Result: Summary: Verification could not run because no trusted sandbox image is configured for `microsoft/vscode-python`. The PR adds no tests, and existing tests do not reference `ProgressReporting` or its progress notifications. The new disposal behavior therefore remains unverified and uncovered. Test runs: 1 not run
|
Bill Schnurr (bschnurr)
approved these changes
Aug 31, 2026
Bill Schnurr (bschnurr)
left a comment
Member
There was a problem hiding this comment.
Approved via Review Center.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #16750
When a language server crashed or was restarted, any active progress notifications (started via
python/beginProgress) would remain orphaned in the UI because theprogressDeferredpromise was never resolved duringdispose().This PR ensures that if the
ProgressReportinginstance is disposed, any pending progress deferred is resolved, closing the orphaned UI notification.