Add link to native REPL information - #26134
Open
Eduardo Villalpando Mello (edvilme) wants to merge 6 commits into
Open
Add link to native REPL information#26134Eduardo Villalpando Mello (edvilme) wants to merge 6 commits into
Eduardo Villalpando Mello (edvilme) wants to merge 6 commits into
Conversation
Member
|
🔒 Automated review in progress — Bill Schnurr (@bschnurr) is auto-reviewing this PR. |
Member
|
Verification: The relevant tests could not be fully run in the isolated environment; this review is not fully verified. Result: Summary: Verification could not run because no trusted sandbox image is configured for `microsoft/vscode-python`, and local execution was not authorized. The PR modifies existing Python and TypeScript tests but adds no new test cases. Linux startup-message behavior lacks coverage because the non-Darwin print test is restricted to Windows. Test runs: 1 not run
|
Bill Schnurr (bschnurr)
approved these changes
Sep 1, 2026
Bill Schnurr (bschnurr)
left a comment
Member
There was a problem hiding this comment.
Approved via Review Center.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #24754
This pull request refactors how shell integration sequences are managed in
python_files/pythonrc.pyby introducing a dedicatedShellIntegrationSequenceenum, and updates related string formatting to use this enum. It also updates user-facing messages in both the Python startup script and the VS Code terminal link provider to include a documentation URL. These changes improve maintainability, clarity, and user guidance.Shell integration refactoring:
ShellIntegrationSequenceenum to centralize shell integration control sequences, replacing hard-coded string literals throughout the code. [1] [2]__str__method in the prompt class to use the new enum values, improving readability and reducing duplication.User guidance improvements:
pythonrc.pyto include a documentation URL, guiding users to more information about the VS Code Native REPL.pythonStartupLinkProvider.tsto match the new message format (excluding the URL), ensuring the link detection logic remains consistent with the Python script output.