adding hover copy button in verbose hover#323121
Open
aiday-mar wants to merge 2 commits into
Open
Conversation
benibenj
previously approved these changes
Jun 26, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request fixes an editor hover UX regression where increasing/decreasing hover verbosity causes the hover’s copy button to disappear. It does so by tracking listeners/copy-button disposables per rendered hover part, so a single part can be updated and have its UI wiring re-established without affecting other parts.
Changes:
- Introduce per-hover-part disposable tracking to manage focus listeners and the copy button independently per rendered part.
- On hover verbosity updates, dispose the previous part’s listeners/copy button and recreate them for the updated part to keep the copy button present.
Comment on lines
+324
to
+326
| // Create per-part disposables so that when an individual rendered part is | ||
| // updated we can dispose its listeners and copy button without affecting | ||
| // the others. |
Comment on lines
+426
to
+439
| // Dispose any listeners/copy button for the previous part at this index | ||
| const prevDisposable = this._perPartDisposables.get(i); | ||
| if (prevDisposable) { | ||
| prevDisposable.dispose(); | ||
| this._perPartDisposables.delete(i); | ||
| } | ||
| this._renderedParts[i] = { | ||
| type: 'hoverPart', | ||
| participant: this._markdownHoverParticipant, | ||
| hoverPart: renderedPart.hoverPart, | ||
| hoverElement: renderedPart.hoverElement, | ||
| }; | ||
| // Recreate listeners and copy button for the updated part. | ||
| this._createListenersForPart(i, this._renderedParts[i]); |
alexdima
approved these changes
Jun 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #321171