Skip to content

chat/voice: land voice answers on question carousels (fix Skipped)#323161

Open
accnops wants to merge 3 commits into
microsoft:meganrogge/voice-mode-fixesfrom
accnops:arthurcnops/voice-integration-latest
Open

chat/voice: land voice answers on question carousels (fix Skipped)#323161
accnops wants to merge 3 commits into
microsoft:meganrogge/voice-mode-fixesfrom
accnops:arthurcnops/voice-integration-latest

Conversation

@accnops

@accnops accnops commented Jun 26, 2026

Copy link
Copy Markdown

Summary

Lets voice users answer VS Code chat question carousel multi-question forms (and approvals) by voice. Fixes the end-to-end break where a voice-spoken selection never landed and the card showed "Skipped".

Three commits, stacked on meganrogge/voice-mode-fixes:

  1. respond_to_session answer/approval plumbing — voice tool dispatch routes question-carousel answers and approvals back into the chat session.
  2. Complete agent-host carousels so voice answers land — agent-host carousels resolve only via their completion promise (carousel.dismiss(answers)ChatInputCompleted), not the event the voice path fired. The answer branch now calls carousel.dismiss(toCarouselAnswers(answers)) in addition to notifyQuestionCarouselAnswer. An empty answer record maps to undefined so a genuine skip becomes Cancel rather than a truthy empty Accept. Adds a pure toCarouselAnswers helper + unit tests.
  3. Guard against stale skip overwrite — after an external dismiss(), a later onDidSubmitRequest auto-skip could call handleSubmit(defaults) and overwrite the resolved answers. skip()/ignore() now also guard on carousel.isUsed. Adds 2 regression tests.

Testing

  • tsc -p src/tsconfig.json --noEmit — 0 errors
  • eslint on changed files — 0 errors
  • Added unit + regression tests for toCarouselAnswers and the carousel skip/ignore guards.

Arthur Cnops added 3 commits June 26, 2026 12:43
…ssion

The voice client collapsed five distinct pending chat constructs into a single
agent_state:"waiting_for_confirmation" and dropped the option list, question
ids, and routing ids, so a voice answer to a questionCarousel form could never
land. The dispatch layer also only knew how to confirmWith a toolInvocation.

Break A (wire): voiceSessionController now emits a typed `pending` payload per
session carrying type (questions|approval|elicitation), the exact
pending_id/request_id/resolve_id/approval_kind, and the per-question schema with
options serialized in displayed (defaults-first) order so a spoken ordinal
matches the screen. The generic delta computer ships it and nulls it on clear.

Break C (apply): voiceToolDispatchService handles respond_to_session by exact
session+part resolution and applies per kind — confirmWith for
toolInvocation/postApproval, accept/reject for elicitation2, confirmation
resend, and notifyQuestionCarouselAnswer for carousels. Answers are resolved
deterministically against the live options (value -> 1-based ordinal -> label,
freeform fallback) and a structured {ok,reason} result lets the backend narrate
corrections.

Extract the carousel option-ordering into chatQuestionCarouselHelpers.ts and
reuse it from the widget, controller, and dispatch so all three agree on order;
add a unit test for ordering and answer resolution.

Lockstep with the voice_code backend respond_to_session protocol change.
A voice answer to a questionCarousel showed "Skipped" and never reached the
agent for vscode-chat-session://local/... (agent-host) sessions. The dispatch
layer resolved a carousel only by firing notifyQuestionCarouselAnswer, an event
consumed solely by the askQuestions and openBrowser tools. Agent-host carousels
resolve exclusively via their completion promise (carousel.completion.complete),
which dispatches ChatInputCompleted back to the agent; voice never settled it,
so the carousel was abandoned and later disposed empty -> isUsed -> "Skipped".

Fix: the answer path now calls carousel.dismiss(answers) when the live part is a
ChatQuestionCarouselData, in addition to the event. dismiss settles the
completion promise (the only agent-host resolution path) and marks the carousel
used in one idempotent call, mirroring the real UI submit which does both.

Empty resolved answers (the user answered nothing) map to undefined via a new
toCarouselAnswers helper so agent-host treats it as a cancel/skip rather than
submitting an empty accept. Unit-tested.
…nswers

ChatQuestionCarouselPart.skip()/ignore() only guarded on the part's own
_isSkipped and allowSkip. If the underlying carousel was resolved elsewhere
(e.g. a voice answer calling dismiss()) after the part had already rendered
interactively, a subsequent onDidSubmitRequest auto-skip would still invoke
onSubmit and overwrite carousel.data with default answers, so the summary
showed defaults instead of the answer that actually landed.

Guard both methods on carousel.isUsed so an already-resolved carousel is never
re-submitted from the UI part, regardless of how it was resolved. Adds
regression tests for the external-resolution race.
@microsoft-github-policy-service

Copy link
Copy Markdown
Contributor

@accnops please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@microsoft-github-policy-service agree [company="{your company}"]

Options:

  • (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@microsoft-github-policy-service agree
  • (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@microsoft-github-policy-service agree company="Microsoft"
Contributor License Agreement

Contribution License Agreement

This Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
and conveys certain license rights to Microsoft Corporation and its affiliates (“Microsoft”) for Your
contributions to Microsoft open source projects. This Agreement is effective as of the latest signature
date below.

  1. Definitions.
    “Code” means the computer software code, whether in human-readable or machine-executable form,
    that is delivered by You to Microsoft under this Agreement.
    “Project” means any of the projects owned or managed by Microsoft and offered under a license
    approved by the Open Source Initiative (www.opensource.org).
    “Submit” is the act of uploading, submitting, transmitting, or distributing code or other content to any
    Project, including but not limited to communication on electronic mailing lists, source code control
    systems, and issue tracking systems that are managed by, or on behalf of, the Project for the purpose of
    discussing and improving that Project, but excluding communication that is conspicuously marked or
    otherwise designated in writing by You as “Not a Submission.”
    “Submission” means the Code and any other copyrightable material Submitted by You, including any
    associated comments and documentation.
  2. Your Submission. You must agree to the terms of this Agreement before making a Submission to any
    Project. This Agreement covers any and all Submissions that You, now or in the future (except as
    described in Section 4 below), Submit to any Project.
  3. Originality of Work. You represent that each of Your Submissions is entirely Your original work.
    Should You wish to Submit materials that are not Your original work, You may Submit them separately
    to the Project if You (a) retain all copyright and license information that was in the materials as You
    received them, (b) in the description accompanying Your Submission, include the phrase “Submission
    containing materials of a third party:” followed by the names of the third party and any licenses or other
    restrictions of which You are aware, and (c) follow any other instructions in the Project’s written
    guidelines concerning Submissions.
  4. Your Employer. References to “employer” in this Agreement include Your employer or anyone else
    for whom You are acting in making Your Submission, e.g. as a contractor, vendor, or agent. If Your
    Submission is made in the course of Your work for an employer or Your employer has intellectual
    property rights in Your Submission by contract or applicable law, You must secure permission from Your
    employer to make the Submission before signing this Agreement. In that case, the term “You” in this
    Agreement will refer to You and the employer collectively. If You change employers in the future and
    desire to Submit additional Submissions for the new employer, then You agree to sign a new Agreement
    and secure permission from the new employer before Submitting those Submissions.
  5. Licenses.
  • Copyright License. You grant Microsoft, and those who receive the Submission directly or
    indirectly from Microsoft, a perpetual, worldwide, non-exclusive, royalty-free, irrevocable license in the
    Submission to reproduce, prepare derivative works of, publicly display, publicly perform, and distribute
    the Submission and such derivative works, and to sublicense any or all of the foregoing rights to third
    parties.
  • Patent License. You grant Microsoft, and those who receive the Submission directly or
    indirectly from Microsoft, a perpetual, worldwide, non-exclusive, royalty-free, irrevocable license under
    Your patent claims that are necessarily infringed by the Submission or the combination of the
    Submission with the Project to which it was Submitted to make, have made, use, offer to sell, sell and
    import or otherwise dispose of the Submission alone or with the Project.
  • Other Rights Reserved. Each party reserves all rights not expressly granted in this Agreement.
    No additional licenses or rights whatsoever (including, without limitation, any implied licenses) are
    granted by implication, exhaustion, estoppel or otherwise.
  1. Representations and Warranties. You represent that You are legally entitled to grant the above
    licenses. You represent that each of Your Submissions is entirely Your original work (except as You may
    have disclosed under Section 3). You represent that You have secured permission from Your employer to
    make the Submission in cases where Your Submission is made in the course of Your work for Your
    employer or Your employer has intellectual property rights in Your Submission by contract or applicable
    law. If You are signing this Agreement on behalf of Your employer, You represent and warrant that You
    have the necessary authority to bind the listed employer to the obligations contained in this Agreement.
    You are not expected to provide support for Your Submission, unless You choose to do so. UNLESS
    REQUIRED BY APPLICABLE LAW OR AGREED TO IN WRITING, AND EXCEPT FOR THE WARRANTIES
    EXPRESSLY STATED IN SECTIONS 3, 4, AND 6, THE SUBMISSION PROVIDED UNDER THIS AGREEMENT IS
    PROVIDED WITHOUT WARRANTY OF ANY KIND, INCLUDING, BUT NOT LIMITED TO, ANY WARRANTY OF
    NONINFRINGEMENT, MERCHANTABILITY, OR FITNESS FOR A PARTICULAR PURPOSE.
  2. Notice to Microsoft. You agree to notify Microsoft in writing of any facts or circumstances of which
    You later become aware that would make Your representations in this Agreement inaccurate in any
    respect.
  3. Information about Submissions. You agree that contributions to Projects and information about
    contributions may be maintained indefinitely and disclosed publicly, including Your name and other
    information that You submit with Your Submission.
  4. Governing Law/Jurisdiction. This Agreement is governed by the laws of the State of Washington, and
    the parties consent to exclusive jurisdiction and venue in the federal courts sitting in King County,
    Washington, unless no federal subject matter jurisdiction exists, in which case the parties consent to
    exclusive jurisdiction and venue in the Superior Court of King County, Washington. The parties waive all
    defenses of lack of personal jurisdiction and forum non-conveniens.
  5. Entire Agreement/Assignment. This Agreement is the entire agreement between the parties, and
    supersedes any and all prior agreements, understandings or communications, written or oral, between
    the parties relating to the subject matter hereof. This Agreement may be assigned by Microsoft.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants