chat: dispose leaked request and toast listeners#323230
Draft
roblourens wants to merge 2 commits into
Draft
Conversation
Own language model cancellation callbacks and browser toast event listeners so they are cleaned up with their request-scoped disposable stores. Add regression coverage for completed language model requests. (Written by Copilot) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses disposable leaks in the workbench’s chat/language-model plumbing by ensuring request-scoped cancellation and toast listeners are properly cleaned up, and by adding a regression test intended to prevent reintroducing the leak.
Changes:
- Dispose request-scoped language model cancellation listeners when a response completes.
- Register browser toast click/close/error listeners in the toast’s disposable store.
- Add a unit test intended to cover the request-completion disposal behavior.
Show a summary per file
| File | Description |
|---|---|
| src/vs/workbench/services/host/browser/toasts.ts | Ensures toast event listeners are disposed along with the toast lifecycle. |
| src/vs/workbench/api/browser/mainThreadLanguageModels.ts | Wraps per-request CTS + cancellation forwarding subscription in a disposable to prevent listener leaks. |
| src/vs/workbench/api/test/browser/mainThreadLanguageModels.test.ts | Adds a regression test around request completion and cancellation-listener disposal. |
Review details
- Files reviewed: 3/3 changed files
- Comments generated: 1
- Review effort level: Low
Cancel the source token after response completion and verify cancellation is no longer forwarded to the extension host. (Written by Copilot) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
npm run typecheck-clientnpm run precommitnpm run gulp compile-clientscripts/test.sh --runGlob '**/mainThreadLanguageModels.test.js'\n-npm run valid-layers-check\n\n(Written by Copilot)