Fix configured customizations in Agents window - #333908
Draft
Paul (pwang347) wants to merge 1 commit into
Draft
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: a4bf98f8-855c-4524-8aa4-52ad8d1abc9c
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Local paths are resolved against ambient workspace roots, and discovery is redundantly repeated per refresh.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Review tier: Balanced
Findings: 2
New issues introduced by this change (2)
| Severity | Finding |
|---|---|
 |
src/vs/workbench/contrib/chat/browser/agentSessions/agentHost/agentHostLocalCustomizations.ts — Adding filesystem-backed local and user storage here makes every scope refresh repeat the same… |
|
src/vs/workbench/contrib/chat/browser/agentSessions/agentHost/agentHostLocalCustomizations.ts — Local configured locations are resolved against the ambient workbench folders because this call… |
What changed in this PR
Syncs configured agent and skill locations into Agent Host sessions while leaving default workspace customizations host-discovered.
Changes:
- Adds configured local/personal locations to customization synchronization.
- Filters default workspace and personal locations appropriately.
- Adds focused enumeration and bundling tests.
| File | Description |
|---|---|
agentHostLocalCustomizations.ts |
Adds configured-location filtering and synchronization. |
enumerateLocalCustomizationsForHarness.test.ts |
Tests configured-location enumeration. |
resolveCustomizationRefs.test.ts |
Tests configured files are bundled. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
48
to
+50
| export const SYNCABLE_STORAGE_SOURCES: readonly PromptsStorage[] = [ | ||
| PromptsStorage.local, | ||
| PromptsStorage.user, |
| const userDisabled = promptsService.getDisabledPromptFiles(type); | ||
| const lists = await Promise.all( | ||
| storageSources.map(storage => promptsService.listPromptFilesForStorage(type, storage, token)), | ||
| SYNCABLE_STORAGE_SOURCES.map(storage => promptsService.listPromptFilesForStorage(type, storage, token)), |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #332919
Validation
npm run typecheck-client./scripts/test.sh --run src/vs/workbench/contrib/chat/test/browser/agentSessions/enumerateLocalCustomizationsForHarness.test.ts --run src/vs/workbench/contrib/chat/test/browser/agentSessions/resolveCustomizationRefs.test.ts(41 passing)chat.agentFilesLocationsandchat.agentSkillsLocations, then confirmed the configured workspace agent and skill are listedScreenshot