Skip to content

Editor textarea: short content unless a screen reader is attached (fixes IME jitter in WebKit) #333909

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
PathGao (PathGao) wants to merge 5 commits into
base: main
Choose a base branch
from
+7 −7
Open

Editor textarea: short content unless a screen reader is attached (fixes IME jitter in WebKit) #333909

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
2fdedad
Editor textarea: short content unless a screen reader is attached
PathGao Sep 2, 2026
9172a4d
Editor textarea: write the composition overlay's scroll offsets after…
PathGao Sep 2, 2026
9b39c2c
Editor textarea: keep the Android exception, one-line comments
PathGao Sep 2, 2026
8ad127c
Merge branch 'main' into textarea-short-content-unless-screen-reader
PathGao Sep 4, 2026
b98cb71
Merge branch 'main' into textarea-short-content-unless-screen-reader
PathGao Sep 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions src/vs/editor/browser/controller/editContext/textArea/textAreaEditContext.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -207,8 +207,8 @@ export class TextAreaEditContext extends AbstractEditContext {
const textAreaInputHost: ITextAreaInputHost = {
context: this._context,
getScreenReaderContent: (): TextAreaState => {
if (this._accessibilitySupport === AccessibilitySupport.Disabled) {
// We know for a fact that a screen reader is not attached
if (this._accessibilitySupport === AccessibilitySupport.Disabled || (this._accessibilitySupport === AccessibilitySupport.Unknown && !browser.isAndroid)) {
// No screen reader is known to be attached; a page here gives WebKit an overflow to scroll during IME composition (monaco-editor#4796)
// On OSX, we write the character before the cursor to allow for "long-press" composition
// Also on OSX, we write the word before the cursor to allow for the Accessibility Keyboard to give good hints
const selection = this._selections[0];
Expand Down Expand Up @@ -559,13 +559,13 @@ export class TextAreaEditContext extends AbstractEditContext {
this._accessibilityPageSize = accessibilityPageSize;
}

// When wrapping is enabled and a screen reader might be attached,
// When wrapping is enabled and a screen reader is attached,
// we will size the textarea to match the width used for wrapping points computation (see `domLineBreaksComputer.ts`).
// This is because screen readers will read the text in the textarea and we'd like that the
// wrapping points in the textarea match the wrapping points in the editor.
const layoutInfo = options.get(EditorOption.layoutInfo);
const wrappingColumn = layoutInfo.wrappingColumn;
if (wrappingColumn !== -1 && this._accessibilitySupport !== AccessibilitySupport.Disabled) {
if (wrappingColumn !== -1 && this._accessibilitySupport === AccessibilitySupport.Enabled) {
const fontInfo = options.get(EditorOption.fontInfo);
this._textAreaWrapping = true;
this._textAreaWidth = Math.round(wrappingColumn * fontInfo.typicalHalfwidthCharacterWidth);
Expand Down Expand Up @@ -748,9 +748,6 @@ export class TextAreaEditContext extends AbstractEditContext {
(textareaSpansSingleToken ? viewLineData.tokens.getPresentation(startTokenIndex) : null)
);

this.textArea.domNode.scrollTop = lineCount * lineHeight;
this.textArea.domNode.scrollLeft = scrollLeft;

this._doRender({
lastRenderPosition: null,
top: top,
Expand All @@ -765,6 +762,9 @@ export class TextAreaEditContext extends AbstractEditContext {
strikethrough: presentation.strikethrough,
fontSize
});
// After `_doRender`, as the branch below does: the offsets are clamped against the size it just set
this.textArea.domNode.scrollTop = lineCount * lineHeight;
this.textArea.domNode.scrollLeft = scrollLeft;
}
return;
}
Expand Down