Update proxy agent to 0.45.0 - #333953
Merged
Christof Marti (chrmarti) merged 3 commits intoSep 2, 2026
Merged
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot started reviewing on behalf of
Christof Marti (chrmarti)
September 2, 2026 09:02
View session
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The explicitly temporary Git dependency must return to a published registry version before merge.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Review tier: Balanced
Findings: None
What changed in this PR
Pins the proxy agent’s macOS certificate-worker implementation for product-build validation.
Changes:
- References proxy-agent commit
354da71. - Updates the lockfile to version 0.45.0.
| File | Description |
|---|---|
package.json |
Adds the temporary Git dependency pin. |
package-lock.json |
Locks the corresponding commit and package metadata. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Christof Marti (chrmarti)
changed the title
Christof Marti (chrmarti)
marked this pull request as ready for review
September 2, 2026 16:45
Christof Marti (chrmarti)
enabled auto-merge (squash)
September 2, 2026 16:45
Don Jayamanne (DonJayamanne)
approved these changes
Sep 2, 2026
Don Jayamanne (DonJayamanne)
approved these changes
Sep 2, 2026
Christof Marti (chrmarti)
deleted the
chrmarti/test-macos-system-cert-worker
branch
September 2, 2026 17:48
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Update
@vscode/proxy-agentto0.45.0in the root and remote dependency manifests.This version loads Node.js system certificates in a worker on macOS and starts loading during proxy resolver creation, preventing slow keychain trust evaluation from blocking the extension-host main thread.
Fixes #333830.
Validation
npm run typecheck-clientnpm run hygiene@vscode/proxy-agent@0.45.0tarball.out/systemCertificatesWorker.js.node_modules.asar. All non-macOS stages passed; macOS failures occurred later in ESRP signing and universal notice comparison.