agentHost: hide routine Codex approval review notices - #333956
Merged
Giuseppe Cianci (Giuspepe) merged 2 commits intoSep 2, 2026
Conversation
Keep individual review outcomes out of chat transcripts while preserving the circuit-breaker warning that interrupts a turn.
Copilot started reviewing on behalf of
Giuseppe Cianci (Giuspepe)
September 2, 2026 09:11
View session
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Timeout and failure warnings are suppressed without alternative user feedback.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Review tier: Balanced
Findings: 1
New issues introduced by this change (1)
| Severity | Finding |
|---|---|
src/vs/platform/agentHost/node/codex/codexAgent.ts — This allowlist also drops non-routine failures. In particular, timedOut is a structured review… |
What changed in this PR
Suppresses routine Codex guardian review notices while retaining circuit-breaker interruption warnings.
Changes:
- Filters guardian warnings by message prefix.
- Adds coverage for review outcomes and interruptions.
- Updates handler documentation.
| File | Description |
|---|---|
codexAgent.ts |
Filters guardian notifications. |
codexAgent.test.ts |
Adds regression tests. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Keep routine successful reviews quiet while preserving structured timeout, aborted, and circuit-breaker feedback in the chat UI.
Giuseppe Cianci (Giuspepe)
marked this pull request as ready for review
September 2, 2026 13:11
Giuseppe Cianci (Giuspepe)
enabled auto-merge (squash)
September 2, 2026 13:11
Ladislau Szomoru (lszomoru)
approved these changes
Sep 2, 2026
Giuseppe Cianci (Giuspepe)
deleted the
agents/debug-fix-vscode-issue-333180
branch
September 2, 2026 15:26
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
Fixes #333180
Testing