Skip to content

agentHost: hide routine Codex approval review notices - #333956

Merged
Giuseppe Cianci (Giuspepe) merged 2 commits into
mainfrom
agents/debug-fix-vscode-issue-333180
Sep 2, 2026
Merged

agentHost: hide routine Codex approval review notices#333956
Giuseppe Cianci (Giuspepe) merged 2 commits into
mainfrom
agents/debug-fix-vscode-issue-333180

Conversation

@Giuspepe

@Giuspepe Giuseppe Cianci (Giuspepe) commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

Summary

  • suppress routine Codex automatic-approval notices from chat transcripts
  • surface timed-out and aborted reviews as compact, collapsible status rows
  • preserve denied-review rationale, the Approve anyway flow, and the circuit-breaker warning
  • add regression coverage for handler, formatting, metadata, and UI adaptation

Fixes #333180

Testing

  • npm run compile-client
  • npm run hygiene
  • ./scripts/test.sh --grep CodexAgent|codexGuardianReview|stateToProgressAdapter (324 passing)
  • ESLint on the changed files
  • live Code OSS Agents UI verification for approved, timed-out, aborted, denied, and interrupted states

Keep individual review outcomes out of chat transcripts while preserving the circuit-breaker warning that interrupts a turn.
Copilot AI balanced review requested due to automatic review settings September 2, 2026 09:11

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

Timeout and failure warnings are suppressed without alternative user feedback.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Review tier: Balanced
Findings: 1 Medium severity

New issues introduced by this change (1)
Severity Finding
Medium severity src/​vs/​platform/​agentHost/​node/​codex/​codexAgent.ts — This allowlist also drops non-routine failures. In particular, timedOut is a structured review…
What changed in this PR

Suppresses routine Codex guardian review notices while retaining circuit-breaker interruption warnings.

Changes:

  • Filters guardian warnings by message prefix.
  • Adds coverage for review outcomes and interruptions.
  • Updates handler documentation.
File Description
codexAgent.ts Filters guardian notifications.
codexAgent.test.ts Adds regression tests.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread src/vs/platform/agentHost/node/codex/codexAgent.ts
Keep routine successful reviews quiet while preserving structured timeout, aborted, and circuit-breaker feedback in the chat UI.
@Giuspepe
Giuseppe Cianci (Giuspepe) marked this pull request as ready for review September 2, 2026 13:11
@Giuspepe
Giuseppe Cianci (Giuspepe) merged commit ea742eb into main Sep 2, 2026
40 checks passed
@Giuspepe
Giuseppe Cianci (Giuspepe) deleted the agents/debug-fix-vscode-issue-333180 branch September 2, 2026 15:26
@vs-code-engineering vs-code-engineering Bot added this to the 1.137.0 milestone Sep 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Agent host (Codex): every auto-approved action posts its approval rationale into the transcript

3 participants