Skip to content

Enhance agent merge widget for accessibility and interaction - #333973

Draft
Lee Murray (mrleemurray) wants to merge 10 commits into
mainfrom
mrleemurray/agent-merge-widget
Draft

Enhance agent merge widget for accessibility and interaction#333973
Lee Murray (mrleemurray) wants to merge 10 commits into
mainfrom
mrleemurray/agent-merge-widget

Conversation

@mrleemurray

Copy link
Copy Markdown
Contributor

This refreshes the Agent Merge system-initiated chat turn so review feedback, failing checks, and merge status are easier to scan without exposing machine-facing content or persistent secondary chrome.

Changes

  • Consolidate review comments, failing checks, conflicts, and branch status into a single severity-led summary.
  • Left-align the widget, move the chevron to the trailing edge, use the standard pull request pill, and omit redundant section headings when only one issue type is present.
  • Reveal the border, source metadata, and trailing controls together on header hover, keyboard focus, or expansion, without activating from the transparent outer stroke.
  • Add a reduced-motion-aware source fade and preserve collapsed widget boundaries in high-contrast themes.
  • Add an Agent Message toggle with a stable accessible name, pressed state, keyboard-only focus treatment, and non-sticky pointer focus.
  • Attach the full summary hover to the interactive disclosure so truncated status text remains discoverable.
  • Add an in-chat fixture using the production chat model, view model, and list widget path, alongside expanded, linked-comment, Markdown, and high-contrast scenarios.
  • Update transcript labels, timeline expectations, and focused unit coverage.

Validation

  • Focused Agent Merge unit tests passed.
  • Targeted ESLint and Stylelint passed.
  • VS Code editor diagnostics reported no errors.
  • git diff --check passed.
  • Component Explorer verified standalone, in-chat, hover, focus, expanded, conditional-section, Agent Message, and dark high-contrast states.

Known unrelated issue: Component Explorer can report duplicate registration of inlineChatWidget.statusPlaceholder during HMR reloads; the Agent Merge fixtures continue to render.

Copilot AI balanced review requested due to automatic review settings September 2, 2026 11:50
@mrleemurray
Lee Murray (mrleemurray) marked this pull request as draft September 2, 2026 11:50
auto-merge was automatically disabled September 2, 2026 11:50

Pull request was converted to draft

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Multi-issue details omit the Review Feedback heading despite the described conditional-heading behavior.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Pull request overview

Refreshes the Agent Merge chat widget for clearer status scanning, interaction, and accessibility.

Changes:

  • Consolidates merge status and adopts standard PR pills.
  • Adds disclosure/toggle interactions, hover behavior, reduced-motion, and high-contrast styling.
  • Expands fixtures and focused tests.
File summaries
File Description
chatWidget.fixture.ts Supports system-initiated fixture messages.
chatAgentMerge.fixture.ts Adds interaction, theme, and in-chat scenarios.
chatAgentMergeContentPart.test.ts Tests summaries, toggle state, and hover targeting.
promptTimelineModel.test.ts Updates timeline expectations.
chatRequestText.test.ts Updates transcript label expectations.
chatAgentMergeContent.css Implements refreshed layout and interaction styling.
chatAgentMergeContentPart.ts Reworks status, disclosure, message toggle, and PR rendering.
Review details
  • Files reviewed: 7/7 changed files
  • Comments generated: 1
  • Review effort level: Balanced

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@github-actions

github-actions Bot commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

Screenshot Changes

Base: 3a01d742 Current: c3f71577

Changed (24)

chat/chatAgentMerge/Comments/Dark
Before After
before after
chat/chatAgentMerge/Comments/Light
Before After
before after
chat/chatAgentMerge/SingleComment/Dark
Before After
before after
chat/chatAgentMerge/SingleComment/Light
Before After
before after
chat/chatAgentMerge/FailingChecks/Dark
Before After
before after
chat/chatAgentMerge/FailingChecks/Light
Before After
before after
chat/chatAgentMerge/CommentsAndFailingChecks/Dark
Before After
before after
chat/chatAgentMerge/CommentsAndFailingChecks/Light
Before After
before after
chat/chatAgentMerge/Conflicting/Dark
Before After
before after
chat/chatAgentMerge/Conflicting/Light
Before After
before after
chat/chatAgentMerge/BehindBase/Dark
Before After
before after
chat/chatAgentMerge/BehindBase/Light
Before After
before after
chat/chatAgentMerge/Expanded/Dark
Before After
before after
chat/chatAgentMerge/Expanded/Light
Before After
before after
chat/chatAgentMerge/ExpandedWithReviewSummary/Dark
Before After
before after
chat/chatAgentMerge/ExpandedWithReviewSummary/Light
Before After
before after
chat/chatAgentMerge/ExpandedAgentMessage/Dark
Before After
before after
chat/chatAgentMerge/ExpandedAgentMessage/Light
Before After
before after
chat/chatAgentMerge/ExpandedDuplicateFileNames/Dark
Before After
before after
chat/chatAgentMerge/ExpandedDuplicateFileNames/Light
Before After
before after
chat/chatAgentMerge/ExpandedMarkdownComment/Dark
Before After
before after
chat/chatAgentMerge/ExpandedMarkdownComment/Light
Before After
before after
chat/chatAgentMerge/ExpandedWithLinkedComments/Dark
Before After
before after
chat/chatAgentMerge/ExpandedWithLinkedComments/Light
Before After
before after

1 insignificant change(s) omitted (≤20 px, Δ≤2). See CI logs for details.

Added (3)

chat/chatAgentMerge/FailingChecks/DarkHighContrast

current

chat/chatAgentMerge/InChat/Dark

current

chat/chatAgentMerge/InChat/Light

current

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants