Fix session-row hover actions and layout in narrow panes - #333980
Merged
Benjamin Christopher Simmonds (benibenj) merged 3 commits intoSep 2, 2026
Merged
Fix session-row hover actions and layout in narrow panes#333980Benjamin Christopher Simmonds (benibenj) merged 3 commits into
Benjamin Christopher Simmonds (benibenj) merged 3 commits into
Conversation
Copilot started reviewing on behalf of
Sandeep Somavarapu (sandy081)
September 2, 2026 12:37
View session
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The fixture neither activates the toolbar-visible state nor participates in screenshot CI.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Review tier: Balanced
Findings: 1
New issues introduced by this change (1)
| Severity | Finding |
|---|---|
 |
src/vs/workbench/test/browser/componentFixtures/sessions/sessionsList.fixture.ts — This regression fixture never enters the toolbar-visible state: dispatch-free rendering does not… |
What changed in this PR
Fixes narrow-pane session rows so titles shrink while hover actions remain visible.
Changes:
- Allows session and nested-chat flex rows to shrink.
- Adds a narrow-layout component fixture.
| File | Description |
|---|---|
sessionsList.css |
Adds min-width: 0 to affected flex rows. |
sessionsList.fixture.ts |
Adds a narrow row with a long title. |
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Contributor
Screenshot ChangesBase: Changed (16)
|
| Before | After |
|---|---|
 |
 |
sessions/blockedSessionsList/BlockedSessionsList_SingleNeedsInput/Light
| Before | After |
|---|---|
 |
 |
sessions/blockedSessionsList/BlockedSessionsList_TwoApprovals/Dark
| Before | After |
|---|---|
 |
 |
sessions/blockedSessionsList/BlockedSessionsList_TwoApprovals/Light
| Before | After |
|---|---|
 |
 |
sessions/blockedSessionsList/BlockedSessionsList_FiveApprovals/Dark
| Before | After |
|---|---|
 |
 |
sessions/blockedSessionsList/BlockedSessionsList_FiveApprovals/Light
| Before | After |
|---|---|
 |
 |
sessions/blockedSessionsList/BlockedSessionsList_FixCIAndApproval/Dark
| Before | After |
|---|---|
 |
 |
sessions/blockedSessionsList/BlockedSessionsList_FixCIAndApproval/Light
| Before | After |
|---|---|
 |
 |
sessions/sessionsList/SessionsList_CustomGroup_LongWorkspaceNarrow/Dark
| Before | After |
|---|---|
 |
 |
sessions/sessionsList/SessionsList_CustomGroup_LongWorkspaceNarrow/Light
| Before | After |
|---|---|
 |
 |
sessions/sessionsList/SessionsList_CustomGroup_Phone/Dark
| Before | After |
|---|---|
 |
 |
sessions/sessionsList/SessionsList_CustomGroup_Phone/Light
| Before | After |
|---|---|
 |
 |
sessions/sessionsList/SessionsList_NestedChatApprovals/Dark
| Before | After |
|---|---|
 |
 |
sessions/sessionsList/SessionsList_NestedChatApprovals/Light
| Before | After |
|---|---|
 |
 |
sessions/sessionsList/SessionsList_NestedChatApprovals_Phone/Dark
| Before | After |
|---|---|
 |
 |
sessions/sessionsList/SessionsList_NestedChatApprovals_Phone/Light
| Before | After |
|---|---|
 |
 |
2 insignificant change(s) omitted (≤20 px, Δ≤2). See CI logs for details.
Added (2)
sessions/sessionsList/SessionsList_NarrowHoverToolbar/Dark
sessions/sessionsList/SessionsList_NarrowHoverToolbar/Light
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Benjamin Christopher Simmonds (benibenj)
approved these changes
Sep 2, 2026
Benjamin Christopher Simmonds (benibenj)
enabled auto-merge (squash)
September 2, 2026 14:59
Benjamin Christopher Simmonds (benibenj)
merged commit Sep 2, 2026
967c9f0
into
main
40 checks passed
Benjamin Christopher Simmonds (benibenj)
deleted the
sandy081/agents/bugfix-general-issue
branch
September 2, 2026 15:00
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request addresses a regression affecting the session-row hover actions in narrow panes. The changes made include:
min-width: 0to session and nested-chat flex rows insessionsList.css. This allows the rows to shrink properly and ensures that titles ellipsize, keeping archive and toolbar actions visible.sessionsList.fixture.tsto reproduce the narrow-pane scenario, allowing for better validation of the fix.Validation
SessionsListcomponent, demonstrating that the Archive action now remains visible within the row in narrow layouts.Results