Component fixtures: support selectable file icon themes - #333985
Merged
Benjamin Christopher Simmonds (benibenj) merged 1 commit intoSep 2, 2026
Merged
Conversation
Allow fixtures to select Seti, Minimal, or no file icon theme while scoping generated theme CSS to each fixture. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot started reviewing on behalf of
Benjamin Christopher Simmonds (benibenj)
September 2, 2026 13:07
View session
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The fixture-only changes are coherent, scoped, documented, and include representative visual coverage.
Review tier: Balanced
Findings: None
What changed in this PR
Adds per-fixture file icon themes while preserving Seti as the default.
Changes:
- Supports Seti, Minimal, and disabled file icons.
- Scopes theme CSS for concurrent fixtures.
- Bundles assets and adds representative tab-bar fixtures.
| File | Description |
|---|---|
fixtureUtilsCss.ts |
Caches and scopes icon-theme stylesheets. |
fixtureUtils.ts |
Loads themes, exposes options/context, and configures services. |
editorTabBar.fixture.ts |
Adds file-icon theme variants. |
testThemeService.ts |
Adds file-icon theme mutation support. |
rspack.serve-out.config.mts |
Copies built-in icon assets for static builds. |
SKILL.md |
Documents fixture file-icon configuration. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Contributor
Screenshot ChangesBase: 2 insignificant change(s) omitted (≤20 px, Δ≤2). See CI logs for details. Added (6)
|
Henning Dieterichs (hediet)
approved these changes
Sep 2, 2026
Benjamin Christopher Simmonds (benibenj)
merged commit Sep 2, 2026
b948a39
into
main
41 checks passed
Benjamin Christopher Simmonds (benibenj)
deleted the
benibenj/agents/component-fixture-icon-theme-options
branch
September 2, 2026 13:55
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fileIconThemeoption with Seti as the default and support for Minimal or no file iconsComponentFixtureContextand fixture editor servicesThis follows up on #333969, which enabled the default Seti file icons in component fixtures.
Validation
b716d485b37aafe4545a377cc44be2ede49b3fbacbb8853f11bdfebe9c036703