automations: refactor: make provider session templates canonical by ulugbekna · Pull Request #334521 · microsoft/vscode

Ulugbek Abdullaev (ulugbekna) · 2026-09-04T15:13:26Z

Summary

This is the architectural follow-up to #333723 and #333949.

Automations are now stored and executed through Agent Host Protocol (AHP), but the workbench still edited their session configuration through the legacy flattened modelId, generic chat mode, and permissionLevel fields. That representation cannot faithfully describe provider-native AHP configuration and caused Mode and Approvals to be conflated or dropped.

This change makes a provider-owned session template canonical for new Automations:

Legacy
  modelId + generic chat mode + permissionLevel

Canonical
  model + custom agent + provider-owned JSON-safe config

It then uses a real provider draft and the existing New Session controls to edit that template, and passes the same initial configuration through both AHP-owned execution and older-host/browser fallback.

Why

The old projection had several structural problems:

generic chat uses mode values such as agent, ask, and edit, while Agent Host providers use their own values such as interactive, plan, and autopilot;
legacy permissionLevel: 'autopilot' represented two now-independent axes:
- Mode = Autopilot;
- Approvals = Assisted;
custom-agent selection and future provider configuration could not round-trip;
unrelated edits could erase provider-owned values that the generic dialog could not represent;
fallback execution created a session first and relied on optional post-create Mode/Approvals setters that Agent Host providers do not implement;
stored elevated approval preferences risked being treated as permission grants instead of being revalidated against current policy when the Automation ran.

Architecture

Target and template have separate authority

The Automation target owns:

workspace or workspace-less execution;
provider/session type;
folder/worktree isolation;
branch.

The provider session template owns:

model;
custom agent;
Mode and Approvals where the provider exposes them;
other provider-defined configuration.

Shared Sessions code remains provider-neutral and does not interpret Copilot-, Claude-, or Codex-specific keys.

Canonical session template

IAutomationSessionTemplate carries:

interface IAutomationSessionTemplate {
	modelId?: string;
	agent?: { uri: string };
	config?: Readonly<Record<string, unknown>>;
}

The existing flat fields remain only as deprecated decode/input aliases for old ledgers and callers. Once an Automation has a canonical template, a shared authority guard prevents stale legacy aliases from mutating it.

Provider-owned Automation drafts

The Automation dialog creates a dedicated provider draft, separate from the normal New Session composer draft.

Providers opt into:

restoring automationConfiguration during draft creation;
capturing the resolved Automation configuration before Save.

The draft synchronizer:

coalesces equal target updates;
serializes target changes;
ignores stale generations;
captures the previous target before retargeting when possible;
caches the latest configuration per concrete target;
bounds synchronization and capture;
distinguishes unavailable, unsupported, replaced, failed, valid-empty, and preserved configuration.

A capture failure therefore cannot be mistaken for a successful request to reset configuration.

Reuse New Session controls

The dialog now renders the same NewSessionConfig and NewSessionControl contributions used by New Session, scoped to the Automation draft.

This gives each selected provider its actual Model, Agent, Mode, and Approvals controls. Repository configuration is intentionally not reused because the Automation target already owns workspace, isolation, and branch.

ChatInputPart remains the prompt editor but uses Automation-specific toolbar menus so generic configuration controls are not duplicated.

Explicit Automation picker changes update the same remembered provider selections used by New Session. Merely opening or cancelling an edit does not.

Lossless AHP projection

The Agent Host Automation store now projects:

AutomationDefinition.session <-> IAutomationSessionTemplate

The projection preserves model, custom agent, and provider config.

Reusable templates exclude values owned by a concrete run or target, including:

per-tool session permission lists;
isolation and branch;
worktree settings;
Agent Merge state;
transient shell initialization scripts.

When writing an edited template back, existing definition-owned values are preserved separately.

Same-provider edits preserve authoritative values the editor has no opinion about. Retargeting to another provider does not carry incompatible model/agent/config state.

AHP and fallback execution converge

AHP execution already creates the run session from AutomationDefinition.session.

The older-host/browser runner now passes the same canonical template during draft creation, before the first request, together with target-owned isolation and branch. It no longer depends on optional post-create Mode/Approvals setters.

The older Copilot Chat sessions provider also implements Automation restore/capture so fallback configuration can round-trip instead of being flattened.

Compatibility and policy

Legacy Autopilot migration

Historical Copilot Automations migrate:

autoApprove = autopilot

to

mode        = autopilot
autoApprove = assisted

The migration also repairs the transitional invalid shape produced around the narrow #333949 fix:

unknown/generic mode + assisted approvals
  -> autopilot mode + assisted approvals

This heuristic is restricted to the historical Copilot Automation boundary. Non-Copilot providers do not acquire Copilot configuration keys.

Preferences are not grants

The stored template is a preference snapshot.

Current provider schema, availability, and managed policy are reapplied when a run starts. If policy requires confirmations, effective approval is clamped at the runtime decision points without rewriting the stored preference.

This also covers policy changes during an active session and avoids elevated fallback if provider resolution fails.

Tool behavior

listAutomations now returns the complete JSON-safe sessionTemplate for canonical rows.

configureAutomation:

preserves omitted templates on unrelated updates;
accepts a complete template or null to reset it;
rejects mixing templates with legacy aliases;
rejects legacy alias updates to an existing canonical template;
validates and clones opaque JSON values;
bounds provider config to depth 32, 10,000 values, and 65,536 serialized characters.

Opaque provider configuration is not emitted through telemetry.

Save and cancellation behavior

Provider capture is asynchronous, so Save must not close the dialog until capture succeeds.

The lifecycle is kept local to the Automation dialog rather than extending the widely used base Dialog widget:

Save/Create validates and starts a bounded capture;
form content becomes inert and aria-busy;
the primary action becomes Saving… and stays disabled;
a live status announces progress;
focus moves to Cancel;
rejection or timeout keeps the dialog open, restores the UI, and focuses an inline error;
Cancel, Escape, and Close cancel the active operation;
successful capture closes with the canonical result.

The local footer reuses standard button styles and platform-specific ordering. The final branch has no changes to the shared base Dialog implementation or tests relative to its merge base.

User-visible behavior

The Automation configuration strip reflects the selected provider rather than generic chat state.
Mode and Approvals can be selected independently.
Existing Automations remain editable when their provider or a saved value is temporarily unavailable; configuration is preserved rather than silently replaced.
Retargeting creates provider-appropriate configuration and does not leak settings between providers.
Save has a visible, cancellable busy state.
The dialog remains keyboard accessible and overflow-free at narrow widths.

Validation

Static and unit coverage

client type-check passed;
full OSS compile passed;
targeted ESLint and stylelint passed;
source-layer validation passed;
whitespace checks passed;
changed-surface matrix: 1,205 passed, 13 platform-gated pending;
full OSS unit suite: 34,078 passed, 470 pending;
20 repeated synchronization/capture race runs passed;
final shared Dialog/Automation regression run: 92 passed.
post-rebase validation on main at 2e12155dfa05: client type-check, targeted ESLint, source-layer validation, fresh client transpile, 468 provider/Automation tests passed with 13 platform-gated pending, and the strict Copilot restart replay passed.

Agent Host E2E

added a recorded Copilot restart scenario proving mode: autopilot and autoApprove: assisted survive host restart and reach the created run session;
focused strict replay passed repeatedly;
the Automation scenario passed in the broader deterministic E2E run.

Live Code OSS

Validated:

create and edit;
reload persistence;
workspace and workspace-less targets;
retarget A -> B -> A;
duplicate;
enable/disable;
Run Now;
delete;
Saving state and Cancel/Escape/Close behavior;
accessible labels, focus, and live status;
desktop and 420px layouts with no horizontal overflow;
zero browser-console errors in the final run.

Reviewer attention / remaining merge gates

The branch has been rebased onto main at 2e12155dfa05. The two provider conflicts were resolved by retaining upstream's configuration-operation serialization and repository-containment behavior while adapting the Automation restore/capture work to those APIs.

Run the cross-platform restart gate. The recorded test should complete cleanly twice on Windows, Linux, and macOS through pipeline 111.
Explicitly sign off on the migration heuristic. There is no per-row version marker for the transitional unknown mode + assisted representation. The repair is narrowly scoped to Copilot, where affected schemas do not admit legitimate unknown modes.
Add live Codex coverage. Provider-neutral behavior and Codex template handling have unit coverage, but the isolated OSS profile used for the final screenshots left chat.agentHost.codexAgent.enabled at its default false. A live pass should enable Codex and verify selection, Codex-native Approvals, save/reload, and Codex -> Copilot -> Codex retargeting.
Review the compatibility boundary. Flat aliases intentionally remain for old data and callers; no new code should write them for canonical Automations.

The branch is broad (52 files), so the commit stack is organized into reviewable layers: migration/policy, canonical domain/storage, provider drafts, New Session control reuse, execution parity, tools/E2E, and robustness fixes.

Known unrelated test/environment findings

The broad test pass also reproduced pre-existing or unrelated failures:

conformance bang-command failures;
Copilot worktree cwd and nested peer-file failures;
Claude replay text drift;
an isolated scenario-runner custom-view activation gap;
component-explorer MCP initialization failures;
Apple /usr/bin/git blocked by the local Xcode license state.

These were isolated from the Automation behavior and are not hidden by success-shaped fallbacks in this change.

UI

Final 420px Automation edit dialog using the provider-backed configuration controls and local asynchronous Save lifecycle. This isolated profile selected Copilot; live Codex coverage remains an explicit draft gate above.

Complete the legacy Automation mapping by preserving Autopilot on the Agent Host mode axis while applying Assisted approvals. Ignore generic chat modes at the AHP boundary and revalidate elevated Copilot approvals against current policy. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 09e55c0c-bf80-42ea-b8e2-fad38a12d986

Preserve provider-owned configuration across compatibility edits, repair existing and provider-less Copilot Automation definitions, and reset incompatible state on retargeting. Enforce managed auto-approval policy at both SDK and host decision points while keeping saved preferences intact. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 09e55c0c-bf80-42ea-b8e2-fad38a12d986

Add a versioned provider-neutral session template projection for model, agent, and opaque configuration. Keep legacy flat writers functional during migration, preserve unknown AHP state on edits and transfers, and clear incompatible configuration on retarget. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 09e55c0c-bf80-42ea-b8e2-fad38a12d986

Let Automation drafts restore and capture provider-owned model, agent, and resolved configuration through the Sessions provider contract. Keep normal New Session defaults isolated, reject replaced draft snapshots, and exclude transient or target-owned values. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 09e55c0c-bf80-42ea-b8e2-fad38a12d986

Drive Automation configuration through a scoped session draft and the same provider-owned pickers as New Session. Capture complete provider state for Agent Host and legacy Copilot paths while preserving unavailable, opaque, removed, and policy-clamped preferences. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 09e55c0c-bf80-42ea-b8e2-fad38a12d986

Pass the complete provider-owned Automation configuration during older-host draft creation so browser fallback and AHP execution use the same template semantics. Keep workspace isolation and branch configuration target-owned. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 09e55c0c-bf80-42ea-b8e2-fad38a12d986

Round-trip complete provider session templates through Automation tools and stop new dialog and AHP projections from writing flattened aliases. Keep legacy rows and inputs compatible while enforcing template-first execution, duplication, telemetry, and rollback semantics. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 09e55c0c-bf80-42ea-b8e2-fad38a12d986

Specify canonical Automation template and draft ownership across Sessions and Agent Host. Add recorded AHP coverage proving independent Mode and Approvals survive host restart into the created run session, and document the remaining Claude/Codex coverage gap. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 09e55c0c-bf80-42ea-b8e2-fad38a12d986

Keep canonical provider templates opaque and authoritative while limiting legacy Autopilot repair to load/import boundaries. Bound dialog capture and preserve per-target configuration across failures and retargeting, retain legacy duplicate/worktree settings, and improve loading accessibility. Add regression coverage for #333723 compatibility, canonical reloads, capture races, and tool configuration limits. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 09e55c0c-bf80-42ea-b8e2-fad38a12d986

Keep the Automation dialog open when provider configuration cannot be captured, expose cancellable saving progress, and serialize draft retargeting. Unify canonical-template authority across stores, require providers to advertise restoration support, preserve definition-owned state, retain scoped picker models across toolbar rebuilds, and keep legacy fallback configuration available. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 09e55c0c-bf80-42ea-b8e2-fad38a12d986

Send providers one canonical Automation configuration object instead of overlapping template channels. Keep keyboard focus on the cancellable action while form content is inert, and make saving and error live regions visible before their announcements change. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 09e55c0c-bf80-42ea-b8e2-fad38a12d986

Refresh the created run session inside the completion retry so the restart E2E validates Mode and Approvals on the settled session rather than an earlier catalog snapshot. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 09e55c0c-bf80-42ea-b8e2-fad38a12d986

Exclude aria-disabled controls from the Automation dialog's custom focus ring so Saving keeps keyboard focus on the cancellable action instead of moving onto the disabled primary button. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 09e55c0c-bf80-42ea-b8e2-fad38a12d986

Avoid extending the widely shared Dialog widget for the Automation editor's provider capture flow. Keep Save failure handling, cancellation, and completion in the Automation dialog while reusing the standard button styles and platform order. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 09e55c0c-bf80-42ea-b8e2-fad38a12d986

Copilot

Copilot review overview

🟡 Changes recommended

Reserved configuration can become unattended permission grants, and reset, fallback-agent, provider-unavailable, and keyboard paths remain incorrect.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Review tier: Balanced
Findings: 1 · 2 · 1

New issues introduced by this change (4)

Severity	Finding
	`src/vs/sessions/contrib/providers/agentHost/browser/agentHostAutomationStore.ts` — The canonical template is merged without removing platform-owned keys. A `configureAutomation`…
	`src/vs/sessions/contrib/automations/browser/automationDialog.ts` — Unavailable saved targets are treated as synchronization failures here, so Save reports a capture…
	`src/vs/sessions/contrib/providers/agentHost/browser/agentHostAutomationStore.ts` — An explicit `sessionTemplate: null` reaches this branch with no template or aliases, but the legacy…
	`src/vs/platform/actions/common/actions.ts` — This menu is owned and consumed only by the Sessions Automation UI. Sessions menu IDs are…

What changed in this PR

Makes provider-owned session templates canonical for Automations while retaining legacy compatibility.

Changes:

Adds template persistence, migration, validation, and AHP projection.
Reuses provider-backed New Session controls and aligns fallback execution.
Adds policy enforcement and broad unit/E2E coverage.

File	Description
`src/vs/workbench/contrib/chat/common/automations/automationTelemetry.ts`	Updates telemetry descriptions.
`src/vs/workbench/contrib/chat/common/automations/automationService.ts`	Adds template authority and serialization.
`src/vs/workbench/contrib/chat/common/automations/automation.ts`	Defines canonical templates.
`src/vs/workbench/contrib/chat/browser/widget/input/chatInputPart.ts`	Supports custom input toolbar menus.
`src/vs/workbench/contrib/chat/browser/actions/chatExecuteActions.ts`	Hides the generic permission picker.
`src/vs/sessions/SESSIONS.md`	Documents Automation draft contracts.
`src/vs/sessions/services/sessions/test/browser/sessionsManagementService.test.ts`	Tests template restoration and isolation.
`src/vs/sessions/services/sessions/test/browser/sessionNavigation.test.ts`	Updates service mock capabilities.
`src/vs/sessions/services/sessions/common/sessionsProvider.ts`	Extends provider configuration contracts.
`src/vs/sessions/services/sessions/common/sessionsManagement.ts`	Extends management APIs.
`src/vs/sessions/services/sessions/browser/sessionsManagementService.ts`	Routes templates into provider drafts.
`src/vs/sessions/contrib/sessions/test/browser/automationsView.test.ts`	Tests canonical duplication.
`src/vs/sessions/contrib/sessions/browser/views/automationsView.ts`	Preserves canonical templates when duplicating.
`src/vs/sessions/contrib/providers/copilotChatSessions/test/browser/sandboxPicker.test.ts`	Updates constructor arguments.
`src/vs/sessions/contrib/providers/copilotChatSessions/test/browser/copilotChatSessionsProvider.test.ts`	Tests fallback restore and capture.
`src/vs/sessions/contrib/providers/copilotChatSessions/browser/copilotChatSessionsProvider.ts`	Implements fallback template support.
`src/vs/sessions/contrib/providers/agentHost/test/browser/localAgentHostSessionsProvider.test.ts`	Tests Agent Host template behavior.
`src/vs/sessions/contrib/providers/agentHost/browser/mobile/mobileChatInputConfigPicker.ts`	Uses provider capabilities for mobile UI.
`src/vs/sessions/contrib/providers/agentHost/browser/baseAgentHostSessionsProvider.ts`	Restores and captures Agent Host templates.
`src/vs/sessions/contrib/providers/agentHost/browser/agentHostAutomationStore.ts`	Projects templates to AHP definitions.
`src/vs/sessions/contrib/providers/agentHost/browser/agentHostAgentPicker.ts`	Scopes cached picker models.
`src/vs/sessions/contrib/providers/agentHost/AGENT_HOST_SESSIONS_PROVIDER.md`	Documents provider behavior.
`src/vs/sessions/contrib/chat/browser/newSessionConfigToolbars.ts`	Extracts shared toolbar helpers.
`src/vs/sessions/contrib/chat/browser/newChatInput.ts`	Reuses toolbar helpers.
`src/vs/sessions/contrib/automations/test/browser/providerAutomationService.test.ts`	Updates migration expectations.
`src/vs/sessions/contrib/automations/test/browser/automationTools.test.ts`	Tests template tool validation.
`src/vs/sessions/contrib/automations/test/browser/automationService.test.ts`	Tests schema and template persistence.
`src/vs/sessions/contrib/automations/test/browser/automationRunner.test.ts`	Tests fallback template forwarding.
`src/vs/sessions/contrib/automations/test/browser/automationDialog.test.ts`	Tests draft synchronization and capture.
`src/vs/sessions/contrib/automations/browser/providerAutomationService.ts`	Migrates provider-backed definitions canonically.
`src/vs/sessions/contrib/automations/browser/media/automationDialog.css`	Styles provider controls and save state.
`src/vs/sessions/contrib/automations/browser/automationTools.ts`	Exposes and validates canonical templates.
`src/vs/sessions/contrib/automations/browser/automationService.ts`	Persists schema-v4 templates.
`src/vs/sessions/contrib/automations/browser/automationRunner.ts`	Aligns fallback session creation.
`src/vs/sessions/contrib/automations/browser/automationDialog.ts`	Manages provider drafts and controls.
`src/vs/sessions/contrib/automations/browser/automationDialogService.ts`	Adds asynchronous save lifecycle.
`src/vs/sessions/AUTOMATIONS.md`	Documents canonical template ownership.
`src/vs/platform/agentHost/test/node/sessionPermissions.test.ts`	Tests policy clamping.
`src/vs/platform/agentHost/test/node/e2e/suites/automationsSuite.ts`	Adds restart execution coverage.
`src/vs/platform/agentHost/test/node/e2e/suites/agentHostE2ESuites.ts`	Registers Automation parity tests.
`src/vs/platform/agentHost/test/node/e2e/KNOWN_ISSUES.md`	Tracks missing provider coverage.
`src/vs/platform/agentHost/test/node/e2e/captures/copilotcli-an-automation-run-restores-mode-and-approvals-after-host-restart.yaml`	Records Copilot replay traffic.
`src/vs/platform/agentHost/test/node/copilotAgentSession.test.ts`	Tests live policy revocation.
`src/vs/platform/agentHost/test/node/agentHostAutomationService.test.ts`	Tests stored migration.
`src/vs/platform/agentHost/test/common/automationMigration.test.ts`	Tests legacy Autopilot migration.
`src/vs/platform/agentHost/node/sessionPermissions.ts`	Enforces approval policy at runtime.
`src/vs/platform/agentHost/node/copilot/copilotAgentSession.ts`	Revokes elevated Copilot permissions.
`src/vs/platform/agentHost/node/agentHostAutomationService.ts`	Migrates persisted definitions.
`src/vs/platform/agentHost/common/sessionConfigKeys.ts`	Defines reusable-template exclusions.
`src/vs/platform/agentHost/common/automationMigration.ts`	Implements compatibility migration.
`src/vs/platform/actions/common/actions.ts`	Adds an Automation toolbar menu ID.

Suppressed comments (3)

src/vs/sessions/contrib/providers/agentHost/browser/baseAgentHostSessionsProvider.ts:3412

Fallback draft creation also forwards reserved template keys unchanged. This bypasses the AHP projection path, so a canonical template from the legacy store/tool can seed per-tool permissions or transient shellInitScripts into an unattended run. Strip non-reusable values before normalizing the template config.
src/vs/sessions/contrib/providers/copilotChatSessions/browser/copilotChatSessionsProvider.ts:1735
Marking the Copilot provider as supporting canonical Automation templates requires restoring every template axis, but this method never applies template.agent. A canonical row containing only agent therefore opens and runs with the provider default mode, while capture merely copies the stale agent field back, so the custom-agent selection is not actually editable or executable in this fallback provider. Restore the agent into the provider's custom-mode model and derive/clear it from the live selection during capture.
src/vs/sessions/contrib/automations/browser/automationDialogService.ts:319
The custom focus trap receives only elements found inside the form, while Save and Cancel are rendered in the separate footer. It intercepts and stops Tab navigation, and the base dialog only discovers links—not custom footer buttons—so keyboard users cannot tab to either action; while the form is inert during save, Tab can also fall into the base handler with no focusable items. Include the footer buttons in this focus order, keeping Cancel reachable during saving.

					const keyboardNavigation = disposables.add(registerAutomationDialogKeyboardNavigation(
						DOM.getWindow(container),
						() => [
							...getFocusableElements(),
							...(saveButton ? [saveButton.element] : []),
							...(cancelButton ? [cancelButton.element] : []),
						],

💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Filter reserved session state at both Agent Host projection and fallback restoration, preserve configuration for unavailable targets, honor explicit template reset semantics, and keep the Automation prompt menu owned by Sessions. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 09e55c0c-bf80-42ea-b8e2-fad38a12d986

Ulugbek Abdullaev (ulugbekna) · 2026-09-04T21:12:35Z

Copilot review

Copilot · 2026-09-04T21:18:07Z

Copilot review

I re-checked the branch state and there are no new file changes to submit since e20b2e8b (the latest review-fix commit). Current CI runs on this branch are in progress and there are no failed jobs yet in the latest review workflow run.

vs-code-engineering · 2026-09-04T21:27:09Z

📬 CODENOTIFY

The following users are being notified based on files changed in this PR:

Sandeep Somavarapu (@sandy081)

Matched files:

src/vs/sessions/services/sessions/browser/sessionsManagementService.ts
src/vs/sessions/services/sessions/common/sessionsManagement.ts
src/vs/sessions/services/sessions/common/sessionsProvider.ts
src/vs/sessions/services/sessions/test/browser/sessionNavigation.test.ts
src/vs/sessions/services/sessions/test/browser/sessionsManagementService.test.ts

Ladislau Szomoru (@lszomoru)

Matched files:

src/vs/sessions/services/sessions/browser/sessionsManagementService.ts
src/vs/sessions/services/sessions/common/sessionsManagement.ts
src/vs/sessions/services/sessions/common/sessionsProvider.ts
src/vs/sessions/services/sessions/test/browser/sessionNavigation.test.ts
src/vs/sessions/services/sessions/test/browser/sessionsManagementService.test.ts

roblourens

[Experimental performance review bot]

Automated experimental performance review.

(Written by Copilot)

roblourens · 2026-09-04T23:26:06Z

+	private async _resolveAutomationSessionMode(session: CopilotCLISession, modeId: string): Promise<void> {
+		const modes = this.chatModeService.createModes(session.resource);
+		try {
+			await modes.waitForPendingUpdates();


[Experimental performance review bot]

Severity: medium

Initial Automation configuration now launches _resolveAutomationSessionMode with void; that method owns a ChatModes instance but disposes it only after waitForPendingUpdates() settles, with no timeout or cancellation tied to deletion, replacement, send completion, or provider disposal.

If custom-agent discovery is hung or delayed by an unavailable/restarting extension host, each older-host/browser Automation run using an unresolved provider/custom mode leaves another ChatModes object, subscriptions, refresh token, and session closure alive. Recurring Automations then cause renderer memory and listener counts to grow for the lifetime of the stalled discovery.

Suggested fix: Register the resolver/ChatModes instance with the draft or provider lifecycle and race pending discovery with that cancellation (and a bounded timeout). Dispose it immediately when the draft is replaced, deleted, committed, or the provider shuts down; also coalesce discovery where multiple runs resolve the same session scope.

(Written by Copilot)

Copilot AI balanced review requested due to automatic review settings September 4, 2026 15:13

Copilot started reviewing on behalf of Ulugbek Abdullaev (ulugbekna) September 4, 2026 15:14 View session

Ulugbek Abdullaev (ulugbekna) and others added 14 commits September 4, 2026 17:16

Ulugbek Abdullaev (ulugbekna) force-pushed the ulugbekna/agents/issue-investigation-assistance branch from 990b621 to 96e0625 Compare September 4, 2026 15:20

Copilot AI reviewed Sep 4, 2026

View reviewed changes

Ulugbek Abdullaev (ulugbekna) commented Sep 4, 2026

View reviewed changes

Comment thread ...2e/captures/copilotcli-an-automation-run-restores-mode-and-approvals-after-host-restart.yaml

vs-code-engineering Bot assigned Ulugbek Abdullaev (ulugbekna) Sep 4, 2026

Copilot started work on behalf of Ulugbek Abdullaev (ulugbekna) September 4, 2026 21:13 View session

Copilot finished work on behalf of Ulugbek Abdullaev (ulugbekna) September 4, 2026 21:18

Ulugbek Abdullaev (ulugbekna) marked this pull request as ready for review September 4, 2026 21:24

roblourens reviewed Sep 4, 2026

View reviewed changes

roblourens approved these changes Sep 5, 2026

View reviewed changes

Navigation Menu

Uh oh!

automations: refactor: make provider session templates canonical - #334521

automations: refactor: make provider session templates canonical#334521
Ulugbek Abdullaev (ulugbekna) wants to merge 15 commits into
mainfrom
ulugbekna/agents/issue-investigation-assistance

Ulugbek Abdullaev (ulugbekna) commented Sep 4, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Ulugbek Abdullaev (ulugbekna) commented Sep 4, 2026

Uh oh!

Copilot AI commented Sep 4, 2026

Uh oh!

vs-code-engineering Bot commented Sep 4, 2026

Uh oh!

roblourens left a comment

Uh oh!

roblourens Sep 4, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

Ulugbek Abdullaev (ulugbekna) commented Sep 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Why

Architecture

Target and template have separate authority

Canonical session template

Provider-owned Automation drafts

Reuse New Session controls

Lossless AHP projection

AHP and fallback execution converge

Compatibility and policy

Legacy Autopilot migration

Preferences are not grants

Tool behavior

Save and cancellation behavior

User-visible behavior

Validation

Static and unit coverage

Agent Host E2E

Live Code OSS

Reviewer attention / remaining merge gates

Known unrelated test/environment findings

UI

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot review overview

🟡 Changes recommended

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Ulugbek Abdullaev (ulugbekna) commented Sep 4, 2026

Uh oh!

Copilot AI commented Sep 4, 2026

Uh oh!

vs-code-engineering Bot commented Sep 4, 2026

📬 CODENOTIFY

Sandeep Somavarapu (@sandy081)

Ladislau Szomoru (@lszomoru)

Uh oh!

roblourens left a comment

Choose a reason for hiding this comment

Uh oh!

roblourens Sep 4, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Ulugbek Abdullaev (ulugbekna) commented Sep 4, 2026 •

edited

Loading