Skip to content

Fix crloewen.lazywslc 0.1.4 UpgradeCode - #413875

Closed
Anders (sredna) wants to merge 1 commit into
microsoft:masterfrom
sredna:Fix-UpgradeCode
Closed

Fix crloewen.lazywslc 0.1.4 UpgradeCode#413875
Anders (sredna) wants to merge 1 commit into
microsoft:masterfrom
sredna:Fix-UpgradeCode

Conversation

@sredna

@sredna Anders (sredna) commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

In preparation for WG-C PR#6277, all UpgradeCodes must be valid GUIDs.

✅ Checklist

📦 Manifest Checklist

  • Checked that there aren't other open pull requests for the same manifest update/change
  • This PR only modifies one (1) manifest
  • Validated manifest locally with winget validate --manifest <path> (validation guide)
  • Tested manifest locally with winget install --manifest <path>
  • Manifest conforms to the 1.12 schema

Note: <path> is the directory containing the manifest you're submitting.

Microsoft Reviewers: Open in CodeFlow

@wingetbot

Copy link
Copy Markdown
Collaborator

Validation Pipeline Run WinGetSvc-Validation-149-413875-20260807-1

@wingetbot

Copy link
Copy Markdown
Collaborator

PullRequest-Error The pull request contains more than one application. Multiple manifests changes must be under the same application.

@microsoft-github-policy-service microsoft-github-policy-service Bot added Needs-Author-Feedback This needs a response from the author. Validation-Guide Something happened during validation. Provide the guide. labels Aug 7, 2026
@sredna

Anders (sredna) commented Aug 7, 2026

Copy link
Copy Markdown
Contributor Author

The pull request contains more than one application.

Yes I am aware which is why I did not tick that checkbox. These are not my applications, I'm just fixing their bugs.

@microsoft-github-policy-service microsoft-github-policy-service Bot added Needs-Attention This work item needs to be reviewed by a member of the core team. and removed Needs-Author-Feedback This needs a response from the author. labels Aug 7, 2026
@stephengillie

Copy link
Copy Markdown
Collaborator

Hi Anders (@sredna),

Unfortunately, we have a repo policy of 1 manifest change (add/modify/remove) per PR. These changes will need to be spread across 9 more PRs to pass this check.

@stephengillie Stephen Gillie (stephengillie) added Needs-Author-Feedback This needs a response from the author. and removed Needs-Attention This work item needs to be reviewed by a member of the core team. labels Aug 8, 2026
@wingetbot

Copy link
Copy Markdown
Collaborator

Validation Pipeline Run WinGetSvc-Validation-149-413875-20260809-1

@sredna Anders (sredna) changed the title Fix invalid UpgradeCodes Fix crloewen.lazywslc 0.1.4 UpgradeCode Aug 9, 2026
@microsoft-github-policy-service microsoft-github-policy-service Bot removed Needs-Author-Feedback This needs a response from the author. PullRequest-Error PR is Invalid labels Aug 9, 2026
@wingetbot wingetbot (wingetbot) added the Manifest-Validation-Error Manifest validation failed label Aug 9, 2026
@microsoft-github-policy-service microsoft-github-policy-service Bot added the Needs-Author-Feedback This needs a response from the author. label Aug 9, 2026
@github-actions

github-actions Bot commented Aug 9, 2026

Copy link
Copy Markdown
Contributor

Warning

Experimental automated suggestion - please verify before acting. This comment was generated by an experimental assistant to help diagnose a manifest validation result. It is advisory only and may be wrong. Feedback: share it in this discussion.

The validation log identified the following manifest issue:

  • crloewen.lazywslc.installer.yamlInstallers[0].AppsAndFeaturesEntries[0].UpgradeCode and Installers[1].AppsAndFeaturesEntries[0].UpgradeCode: Value type not permitted by 'type' constraint — the schema requires a bare GUID string without curly braces. The submitted value {192B9DA8-24E6-485F-A2EE-5A2B57D02B24} (with braces) is not accepted; it should be 192B9DA8-24E6-485F-A2EE-5A2B57D02B24.

Please update the manifest and allow validation to run again.

Validation evidence

Head SHA: e655e5be3868f9764ce97bac034cfeb6191ddda1

Validation run: https://dev.azure.com/shine-oss/8b78618a-7973-49d8-9174-4360829d979b/_build/results?buildId=384847

Relevant reference: https://github.com/microsoft/winget-pkgs/tree/master/doc/manifest/schema/1.6.0

Template: msftbot/authorAssist/manifestValidation

Template: msftbot/authorAssist/manifestValidation by Manifest Validation Diagnosis

@wingetbot

Copy link
Copy Markdown
Collaborator

Validation Pipeline Run WinGetSvc-Validation-149-413875-20260809-2

@microsoft-github-policy-service microsoft-github-policy-service Bot removed Manifest-Validation-Error Manifest validation failed Needs-Author-Feedback This needs a response from the author. labels Aug 9, 2026
@stephengillie

Copy link
Copy Markdown
Collaborator

Close with reason: Duplicate of #414603;

@microsoft-github-policy-service microsoft-github-policy-service Bot added the Resolution-Duplicate This issue or pull request already exists label Aug 10, 2026
@stephengillie

Copy link
Copy Markdown
Collaborator

Close with reason: Duplicate of #414604;

@stephengillie

Copy link
Copy Markdown
Collaborator

Close with reason: Duplicate of #414602;

@stephengillie

Copy link
Copy Markdown
Collaborator

Close with reason: Duplicate of #414606;

@stephengillie

Copy link
Copy Markdown
Collaborator

Close with reason: Duplicate of #414608;

@stephengillie

Copy link
Copy Markdown
Collaborator

Close with reason: Duplicate of #414599;

@microsoft-github-policy-service

Copy link
Copy Markdown
Contributor

Hello Anders (@sredna),

We've identified this as a duplicate of another issue or PR that already exists. This specific instance is being closed in favor of the linked issue. Please add your 👍 to the other issue to raise its priority. Thanks for your contribution!

Template: msftbot/duplicate/closed

@sredna

Copy link
Copy Markdown
Contributor Author

Stephen Gillie (@stephengillie) why did you close this? The bot is confused because this PR was changed to just one manifest. If you check master, the file this PR is for has still not been updated...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Resolution-Duplicate This issue or pull request already exists Validation-Executable-Error Validation-Guide Something happened during validation. Provide the guide.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants