Skip to content
View midasbal's full-sized avatar

Block or report midasbal

Block user

Prevent this user from interacting with your repositories and sending you notifications. Learn more about blocking users.

You must be logged in to block users.

Content in all repositories owned by your account will be closed.
Maximum 250 characters. Please don’t include any personal information such as legal names or email addresses. Markdown is supported. This note will only be visible to you.
Report abuse

Contact GitHub support about this user’s behavior. Learn more about reporting abuse.

Report abuse
midasbal/README.md

midasbal: professionally suspicious of your happy path

$ merged

Scale remaining order amounts exactly, not through basis points  ProjectOpenSea/seaport-js#991
A basis-points detour under-scaled partial fills. On a 9 ETH order partially filled, the default fulfill path built a 5.9994 ETH transaction where the contract required 6, reverting an ordinary fill with InsufficientNativeTokensSupplied. Traced to a sibling fix that never reached these two functions, verified against seaport-core that the on-chain fill fraction is exact-or-revert, and covered by a regression test that fails on main with the exact wei mismatch.

Make the per-IP token bucket thread-safe under concurrent requests  flop-labs/technocore-chat#163
take() and refund() did an unlocked read-modify-write on the shared per-IP bucket map, and Starlette runs those sync handlers in a threadpool, so two requests from one IP could read the same bucket before either wrote back and both were granted: a lost update that lets a burst overspend its own rate limit. Closed it with a lock around both read-modify-write sites, and a regression test that forces the interleaving and runs red on main, green with the lock.

Classify unseal failures as a typed error to stop a doomed retry loop  FhenixProtocol/cofhesdk#412
On the decryptForView path, an unseal failure (wrong key, tampered payload, malformed nonce) threw a plain Error instead of the CofheError the rest of the decrypt flow uses. So callers could not branch on error.code, and useCofheDecrypt, which only stops retrying on CofheError, kept re-submitting the whole seal-output request to the threshold network for a failure that is deterministic and can never succeed. Reclassified these as CofheError with code SealOutputFailed, with error context limited to byte lengths so no key material leaks, plus failure-path tests covering wrong key, corrupted payload, and malformed nonce.

$ more

  • KeeperHub/keeperhub#2123 soft-delete regression that returned a false 409 on workflows whose run history was purged, traced to the commit and fixed.
  • agentcommercekit/ack#176 CAIP-2 namespace regex corrected to accept spec-legal hyphens, plus a test that had been passing for the wrong reason.
  • getoptimum/optimum-common#191 a reusable uint64 chain_id parser for the shared library, closing the tracking issue.
  • stellar/rs-soroban-sdk#2056 drifted contractimport! rustdoc examples corrected, a nonexistent wasm file and the wrong generated client name.

$ about

midasbal (Taylan Bal). Solo web3 developer, EVM and Soroban. Most of my useful work happens in the gap between what a contract promises and what it actually does. Currently moving into smart contract security and auditing, which is mostly this, with a job title.

Pinned Loading

  1. octra-fhe-sandbox octra-fhe-sandbox Public

    Asynchronous TUI and Branchless FHE Smart Contract Sandbox for the Octra Network.

    Python 1

  2. Interlock Interlock Public

    A safety-gated execution layer for autonomous onchain agents. Simulate, verify, sign, and audit every action, built on KeeperHub.

    TypeScript

  3. Revoca Revoca Public

    Compliance-reactive lending on Cleanverse. A-Pass tier sets collateral ratios; revocation, expiry, or tier-drop triggers a safe, auditable unwind with grace, self-cure, and reinstatement.

    TypeScript

  4. Lucid Lucid Public

    Non-custodial trading for DreamDEX binary event contracts on Somnia: model-implied fair value, keeperless on-chain auto-redeem via the reactivity precompile, and market-maker liquidity.

    TypeScript