Refactor RebateService for Tech Interview - #1
Open
miguelfj wants to merge 4 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implemented the Strategy pattern to make it easier for developers to add new incentive types. New incentive strategies can be registered in the dependency injection container without modifying the RebateService class.
Refactored the RebateService class.
Implemented the storage logic required for this exercise.
Added unit tests for the incentive calculators and RebateService.
Implemented command-line execution for the Rebate Runner.
Note
The storage implementation uses in-memory data stores to keep the project focused on the exercise requirements.