Skip to content

fix: prevent agent model picker button side effects - #3

Open
WangShen007 wants to merge 1 commit into
mingchen666:mainfrom
WangShen007:fix/agent-model-picker-button-type
Open

fix: prevent agent model picker button side effects#3
WangShen007 wants to merge 1 commit into
mingchen666:mainfrom
WangShen007:fix/agent-model-picker-button-type

Conversation

@WangShen007

@WangShen007 WangShen007 commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Set the agent model configuration button to an explicit non-submit button type.
  • Stop/prevent the click event from bubbling to the surrounding selectable row, so opening model config no longer triggers the unwanted navigation/return behavior.

Upstream status note

  • After the maintainer's latest update, the author may have already fixed the issue; user re-testing on Windows 11 indicates the current upstream behavior appears to be working correctly. This PR can be treated as a supplemental minimal fix/reference if still needed.

Linked issue

Closes #1

Test plan

  • Windows 11 real-machine test.
  • Ran pnpm dev from C:\notebook\Reviva.
  • Verified Vite served successfully and the Electron window launched as Reviva.
  • Verified clicking the assistant model configuration button no longer triggers the previous row navigation/return behavior.

Closes mingchen666#1

Tested on Windows 11 with pnpm dev: Vite served successfully and the Electron window launched as Reviva; verified the model config button no longer triggers the previous navigation/return behavior.
@mingchen666
mingchen666 force-pushed the main branch 2 times, most recently from 131d38f to 189c8c9 Compare July 14, 2026 03:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

智能体管理中的内置智能体无法配置模型,点击模型配置后直接返回

1 participant