fix(reward): grade committed MC letter, not first echoed option (#124)#217
Open
kiannidev wants to merge 1 commit into
Open
fix(reward): grade committed MC letter, not first echoed option (#124)#217kiannidev wants to merge 1 commit into
kiannidev wants to merge 1 commit into
Conversation
…-router#124) Drop the line-start A)/B) pattern that matched echoed option lists via re.search(), and let the last-line fallback recover bare or trailing final letters so correct answers stop scoring 0. Co-authored-by: Cursor <cursoragent@cursor.com>
github-actions
Bot
added
docs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #124: when a model echoes the option list (
A) …,B) …) then commits to a final letter,extract_choice_letterreturnedAviare.search()on the line-start pattern.Change
_CHOICE_PATTERNStests/test_reward_checkers.pyTest plan
pytest tests/test_reward_checkers.py— 15 passed