Split into backend-agnostic core + per-backend serving packages#60
Open
mtelvers wants to merge 1 commit into
Open
Split into backend-agnostic core + per-backend serving packages#60mtelvers wants to merge 1 commit into
mtelvers wants to merge 1 commit into
Conversation
mtelvers
force-pushed
the
proto/backend-agnostic
branch
from
dfd31d3 to
6fc4251
Compare
Recording and collection no longer depend on a concurrency library, so metric-defining libraries depend only on `prometheus`; an application chooses Lwt or Eio only when it serves metrics. - prometheus (core): Lwt-free, direct-style. CollectorRegistry.collect returns a plain snapshot; a collector may perform I/O via effects, handled by whatever scheduler runs collect. Includes the direct-style timing helpers (Gauge.time, track_inprogress, Summary.time). - prometheus-app: backend-free text-format renderer + GC collectors (no cohttp, no concurrency library). - prometheus-cohttp: a /metrics handler functor over cohttp's Cohttp.Generic.Server.S, usable with any cohttp backend. - prometheus-lwt (+ .unix): Lwt collectors (register_lwt), an Lwt collect that merges the core's synchronous metrics, Lwt timing helpers, and the cohttp-lwt server + cmdliner + logging. - prometheus-eio: a cohttp-eio handler; async collection needs no special machinery under Eio, and timing reuses the core's direct-style helpers. Lower bounds are 4.08 for the non-Eio packages and 5.0 for prometheus-eio. Tests cover the core, the Lwt sync+async merge, and the effects-driven Eio path under Eio_main. README updated.
mtelvers
force-pushed
the
proto/backend-agnostic
branch
from
6fc4251 to
794d5cb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recording and collection no longer depend on a concurrency library, so metric-defining libraries depend only on
prometheus; an application chooses Lwt or Eio only when it serves metrics./metricshandler functor over cohttp'sCohttp.Generic.Server.S, usable with any cohttp backend.register_lwt), an Lwt collect that merges the core's synchronous metrics, Lwt timing helpers, and the cohttp-lwt server + cmdliner + logging.Tests cover the core (incl. an effects-driven collector), the Lwt sync+async merge, and the Eio path under Eio_main. README updated.
Replaces #59.