Skip to content

test(mcp): report what was counted, not just the failure count #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bhyi4 merged 1 commit into from
Aug 24, 2026
Merged

test(mcp): report what was counted, not just the failure count #6

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,9 @@ jobs:
'arc_close','build_handoff','ralph_gate_check','arc_prereg','verify_gate',
'status','arc_list')]
assert len(tools) == 12, tools
print("yeoul-mcp OK — 12 tools")
# ASCII only: the em-dash renders as "?" on the Windows console, which reads like
# a mojibake defect in the log when nothing is actually wrong.
print("yeoul-mcp OK - 12 tools")
PY
- name: _run subprocess contract (stdin never inherited, UTF-8 pinned)
run: python mcp/tests/test_run_contract.py
15 changes: 14 additions & 1 deletion mcp/tests/test_run_contract.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,9 +29,11 @@
from yeoul_mcp import server # noqa: E402

FAIL = []
RAN = []


def check(desc, cond, detail=""):
RAN.append(desc)
print((" ok " if cond else " FAIL ") + desc + ((" -- " + detail) if detail and not cond else ""))
if not cond:
FAIL.append(desc)
Expand Down Expand Up @@ -122,7 +124,18 @@ def main():
test_stdin_not_inherited(tmp)
test_utf8_pinned_under_hostile_locale(tmp)
test_missing_script_is_not_a_pass(tmp)
print("\n%s (%d failed)" % ("all _run contract tests passed" if not FAIL else "CONTRACT TESTS FAILED", len(FAIL)))
# 🔴 Print WHAT WAS COUNTED, not just the failure count. A run that collected zero checks
# prints "0 failed" too, so that summary cannot tell "everything passed" apart from
# "nothing ran" — and the summary line is what a human quotes later, not the ok lines.
# (substance_check.py already reports `n/n (...)`; these two summaries now match.)
if not RAN:
# Decide BEFORE printing: a summary that says "passed" above a failure line is the
# same trap one line lower down.
print("\nCONTRACT TESTS FAILED: no checks ran at all — an empty run is not a pass")
return 1
print("\n%s: %d/%d checks passed"
% ("all _run contract tests passed" if not FAIL else "CONTRACT TESTS FAILED",
len(RAN) - len(FAIL), len(RAN)))
return 1 if FAIL else 0


Expand Down
Loading