Skip to content

Support UTF-8 SSIDs - #845

Open
paysonwallach wants to merge 1 commit into
mjg59:masterfrom
paysonwallach:utf-8-encoding
Open

paysonwallach wants to merge 1 commit into
mjg59:masterfrom
paysonwallach:utf-8-encoding

Conversation

@paysonwallach

Copy link
Copy Markdown

Context

Pairing over a WiFi network whose name contains non-ASCII characters fails.

Proposed change

Treat the SSID as opaque bytes instead of trying to decode each character.

I must confess that Claude proposed this solution. It's not clear to me why the current implementation does not work.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New device
  • New product id (the device is already supported with a different id)
  • New feature (which adds functionality to an existing device)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests
  • Documentation

Checklist

  • The code change is tested and works locally.
  • The code has been formatted using Black.
  • The code follows the Zen of Python.
  • I am creating the Pull Request against the correct branch.
  • Documentation added/updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant