Repository navigation
chore: use patched Node runtimes in CI - #983
Conversation
Pin targets to 22.23.4 and 24.22.1 and move EOL Node 20 gates to Node 22 without dropping their checks.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Merge Risk: ⚪ Minimal · up to
|
Preserve Vite 7.3.5 -> 7.3.7 dependency-only changes; incorporate patched Node CI target selection from merged #983.
Summary
Verification
Supplementary evidence: before/after YAML was parsed and compared, allowing only Node selections, gate predicates and display/comment updates; both exclusive gates and benchmark retention were checked. The final body was validated with the repository readiness functions using the actual changed-file list. Existing local repositories were inaccessible and Git transport failed, so no local baseline or local Git-dependent readiness command is claimed. The actual Git-dependent PR readiness command passed in GitHub PR Check. Current remote main was used and local changes were untouched. Existing open #981/#982 do not touch workflows; previously merged fixes are not reimplemented.
Merge Readiness
Tracking issue: User-requested eMudhra CI remediation; upstream nodejs/node#66871.
Scoped checks run: YAML semantic diff, gate/matrix preservation, exact changed-file list, repository PR-body validation functions; CI, PR Check and Release Readiness all passed at c1e3cd7.
Why full baseline is not required: No baseline waiver is requested. No product files changed. Existing required PR CI passed for the patched runtime selection and retained gates; full local verification remains unavailable and is not claimed.
Self Review
Self-review workflow: rawsql-task-orchestrator impact routing, acceptance-planning, pr-readiness, changeset-classification, consistency and concept-boundary review, pre-pr-retro-gate and human-acceptance review over this exact diff/body.
Self-review result: Version/gate consistency and executed CI checks have no remaining blocker; final consistency, concept-boundary, pre-PR retro and human-acceptance reviews were repeated against these results. The missing minimal-orchestration helper was reported and the requester explicitly instructed the already delegated worker to continue; it is not claimed as executed. No tracked retro item is present; the local task retro CI completion item is resolved by the successful runs.
Concept-review workflow: Explicit no-concept-impact review against root AGENTS and workflow-only changed paths.
Concept-review result: No Concept, Process, DFD, package boundary, SQL, AST, model or human-owned meaning changes.
CLI Surface Migration
No-migration rationale: Only CI Node targets and corresponding lane predicates/comments change.
Upgrade note: No product CLI upgrade is introduced.
Deprecation/removal plan or issue: The EOL Node 20 CI lane is retired; product engines and API remain unchanged.
Docs/help/examples updated: No product commands, help or examples change.
Release/changeset wording: no-release; repository-only CI maintenance. Apply the existing no-release label for publish-workflow guardrail classification; keep publish smoke enabled.
Scaffold Contract Proof
No-proof rationale: No scaffold generator/template/output changes.
Non-edit assertion: Product and scaffold paths are unchanged.
Fail-fast input-contract proof: Existing input contracts remain unchanged.
Generated-output viability proof: Existing consumer and release-readiness checks remain enabled.
Final CI evidence
Summary by CodeRabbit