fix: validate exception candidate versions - #5
Open
stefan-jansen wants to merge 1 commit into
Open
Conversation
stefan-jansen
added
compatibility: affected
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #4.
The reusable qualification workflow now checks out the caller with tags, builds its wheel, reads the declared version from wheel metadata, and validates that version against the configured exception range.
Before this change, Diagnostic 0.1.2 incorrectly passed
python-315-scipy, whose approved range ends before 0.1.2. The corrected command rejects Diagnostic 0.1.2 and still accepts the current Data and Engineer candidates.Verified:
uv run ruff check .uv run ruff format --check .uv run ty checkuv run pytest -q(81 passed)uv run mkdocs build --strictpre-commit run --all-files