Repository navigation
Fix dynamic SUT listing for OpenAI and Together dedicated - #1650
Open
kaulastudies wants to merge 1 commit into
Open
kaulastudies wants to merge 1 commit into
kaulastudies wants to merge 1 commit into
Conversation
|
MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅ |
Author
|
recheck |
kaulastudies
force-pushed
the
feat/dynamic-sut-listing-1644
branch
from
October 15, 2026 17:16
77fe4fe to
57fdaf5
Compare
Author
|
Refreshed this PR against current Validation on the refreshed branch:
I also ran the full suite locally on Windows. Its remaining failures are environment-specific and unrelated to this diff (Linux-only Together serverless behavior remains unchanged. Ready for renewed review when convenient. |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes dynamic SUT listing for two provider paths that can authoritatively enumerate models/endpoints:
maker/modeland bare deployment names to SUT definitions.This intentionally does not change:
Duplicate Together dedicated deployments are de-duplicated by SUT UID, and malformed/empty deployment entries are ignored.
Validation
tests/modelgauge_tests/test_dynamic_sut_factory.py: passed in isolationtests/modelgauge_tests/test_sut_factory.py: passed in a fresh pytest processgit diff --check: passedThe two regression modules are run in separate pytest processes because
test_dynamic_sut_factory.pyintentionally defines invalidDynamicDriverSUTFactorysubclasses while testingDRIVER_NAMEvalidation; runningtest_sut_factory.pyafterward in the same interpreter can expose those temporary subclasses to factory auto-discovery.All new provider-listing behavior is covered with mocked, network-free tests.
Closes #1644