Skip to content

Fix dynamic SUT listing for OpenAI and Together dedicated - #1650

Open
kaulastudies wants to merge 1 commit into
mlcommons:mainfrom
kaulastudies:feat/dynamic-sut-listing-1644
Open

kaulastudies wants to merge 1 commit into
mlcommons:mainfrom
kaulastudies:feat/dynamic-sut-listing-1644

Conversation

@kaulastudies

Copy link
Copy Markdown

Summary

Fixes dynamic SUT listing for two provider paths that can authoritatively enumerate models/endpoints:

  • OpenAI: discovers available models through the existing OpenAI models API and maps them to ModelBench SUT definitions.
  • Together dedicated: discovers deployments from the account's Together project endpoints and maps both maker/model and bare deployment names to SUT definitions.

This intentionally does not change:

Duplicate Together dedicated deployments are de-duplicated by SUT UID, and malformed/empty deployment entries are ignored.

Validation

  • OpenAI + Together provider tests: 17 passed, 2 skipped
  • tests/modelgauge_tests/test_dynamic_sut_factory.py: passed in isolation
  • tests/modelgauge_tests/test_sut_factory.py: passed in a fresh pytest process
  • Black: passed
  • MyPy on the two source files: passed
  • git diff --check: passed

The two regression modules are run in separate pytest processes because test_dynamic_sut_factory.py intentionally defines invalid DynamicDriverSUTFactory subclasses while testing DRIVER_NAME validation; running test_sut_factory.py afterward in the same interpreter can expose those temporary subclasses to factory auto-discovery.

All new provider-listing behavior is covered with mocked, network-free tests.

Closes #1644

@kaulastudies
kaulastudies requested a review from a team as a code owner September 14, 2026 11:55
@github-actions

github-actions Bot commented Sep 14, 2026 •

Copy link
Copy Markdown

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

@kaulastudies

Copy link
Copy Markdown
Author

recheck

@kaulastudies
kaulastudies force-pushed the feat/dynamic-sut-listing-1644 branch from 77fe4fe to 57fdaf5 Compare October 15, 2026 17:16
@kaulastudies

Copy link
Copy Markdown
Author

Refreshed this PR against current main and revalidated the actual changed paths.

Validation on the refreshed branch:

  • OpenAI/Together focused regression suite: 12 passed, 2 skipped
  • git diff --check: passed
  • Black on touched files: passed
  • current ModelBench MyPy command: passed (notes only)

I also ran the full suite locally on Windows. Its remaining failures are environment-specific and unrelated to this diff (Linux-only SIGALRM / faulthandler.register, missing Graphviz system binaries, Windows path-regex behavior, the fork remote URL assertion, and a local port-binding collision). Upstream CI runs on Ubuntu, so I am leaving Linux confirmation to the PR checks rather than changing unrelated tests.

Together serverless behavior remains unchanged. Ready for renewed review when convenient.

@kaulastudies
kaulastudies deployed to Scheduled Testing October 15, 2026 17:16 — with GitHub Actions Active

This branch was successfully deployed

1 active deployment
Scheduled Testing — 57fdaf5c Deployed Oct 15, 2026 by kaulastudies via build #2604
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Investigate dynamic SUT listing failures

1 participant