Repository navigation
Increase max_tokens for security 1.1 - #1697
Merged
Merged
Conversation
|
MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅ |
wpietri
requested changes
Oct 13, 2026
wpietri
left a comment
wpietri
left a comment
Contributor
There was a problem hiding this comment.
This seems plausible, but I'd love to see some tests that show that this accomplishes what you're intending.
Contributor
Author
|
@wpietri I added some unit tests. |
Contributor
|
@bkorycki what does this address? |
rogthefrog
approved these changes
Oct 13, 2026
Contributor
Author
|
@rogthefrog it addresses #1696 . I believe the idea is that jailbreaks elicit longer responses, so we need to increase the max tokens accordingly. |
wpietri
approved these changes
Oct 14, 2026
wpietri
left a comment
wpietri
left a comment
Contributor
There was a problem hiding this comment.
Sorry for the confusion, but those tests don't strike me as helpful; they're just asserting that the config is the config, something that we can tell by looking at the code. For now just go ahead and remove them.
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.