Repository navigation
Annotations flag - #1700
Open
dhosterman wants to merge 4 commits into
Open
Annotations flag#1700dhosterman wants to merge 4 commits into
dhosterman wants to merge 4 commits into
Conversation
In this case, we want to ensure that both --annotations is passed AND the prompts are shareable.
|
MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅ |
wpietri
approved these changes
Oct 21, 2026
| try: | ||
| run_and_report_benchmark(benchmark, sut, max_instances, debug, json_logs, run_path, output_dir, run_uid, user) | ||
| run_and_report_benchmark( | ||
| benchmark, sut, max_instances, debug, json_logs, run_path, output_dir, run_uid, user, include_annotations |
Contributor
There was a problem hiding this comment.
This is fine for this PR, but at some point we should refactor to extract object(s) from this long parameter list.
| return True | ||
|
|
||
|
|
||
| def only_shareable_non_official_annotations_are_included(annotation_file_path) -> bool: |
Contributor
There was a problem hiding this comment.
I might rename this assert_only_... and get rid of the return statement, as most of the work is asserting.
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.