Feature/woodelf stii fsii fbii - #595
Open
ron-wettenstein wants to merge 6 commits into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
I recently supported STII, FSII and FBII indices in Woodelf.
This PR allow shapiq to use Woodelf also on these indices.
TreeExplainer will use Woodelf on n*m>100000 for interventional SHAP.
It can also use Woodelf on STII, FSII and FBII in path dependent when backend="woodelf" (but not by default).
shapiq[tree] now depends on woodelf_explainer=0.4.7 version (instead of 0.4.6).
Public API Changes
How Has This Been Tested?
Added tests the compare shapiq's output to Woodelf's on these indices and make sure they are identical.
Also validated it locally.
The woodelf package also has its own tests for this logic.
Checklist
CHANGELOG.md(if relevant for users).