Skip to content
This repository was archived by the owner on Jul 13, 2023. It is now read-only.
This repository was archived by the owner on Jul 13, 2023. It is now read-only.

Tokens in redirect URL need to be of short lifetime #4

Description

@muhlemmer

Currently all tokens generated have a single configuration option for Expiration. If this is set to a high interval, it is possible to re-use a URL based token redirect and re-initiate a logged-out session.

Instead, redirected tokens should have a short expiration time. Refreshed tokens usually live in a client session, header or cookie and can have a longer interval. Therefore consumers will need to refresh their token upon the first opportunity after redirect.

The following things need a bit of refactoring:

  1. The authReply method should accept a time.Time instead of looking to the server config.
  2. AuthenticatePwUser and RefreshJWT gRPC methods should accept a time stamp, so the consumer decides the requirements.
  3. Adjust the admin login form to use short timeouts.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

enhancementNew feature or request

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions