Skip to content

fix: resolve mobilecli binary from per-platform optional dependency - #282

Merged
gmegidish merged 1 commit into
mainfrom
fix/mobilecli-binary-resolution
Sep 1, 2026
Merged

fix: resolve mobilecli binary from per-platform optional dependency#282
gmegidish merged 1 commit into
mainfrom
fix/mobilecli-binary-resolution

Conversation

@gmegidish

@gmegidish gmegidish commented Sep 1, 2026

Copy link
Copy Markdown
Member

Since mobilecli 1.0.7 the binaries ship in per-platform optional dependencies (@mobilenext/mobilecli-<platform>-<arch>) instead of mobilecli/bin. Update resolveMobilecliBinary to resolve the platform package from mobilecli's own location, add win32-arm64 support, and fail with a clear reinstall message when the platform package is missing.

@coderabbitai

coderabbitai Bot commented Sep 1, 2026

Copy link
Copy Markdown

Warning

Review limit reached

  • Run on-demand review

On-demand reviews are free for the next 19 days. After that, they cost $0.25 per reviewed file.

Or wait 19 minutes for your next included review.

Check out review usage here.

View limit details

Limit details: You’ve used all 2 included reviews currently available. Your 51 included PR review attempts over the past 7 days set your current allowance at 2 reviews per hour.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Essentials

Run ID: 8539cc25-2174-46f5-89fd-9c6de9e0dd05

📥 Commits

Reviewing files that changed from the base of the PR and between 3870119 and e0983db.

📒 Files selected for processing (2)
  • packages/driver-mobilecli/src/resolve-binary.test.ts
  • packages/driver-mobilecli/src/resolve-binary.ts

Comment @coderabbitai help to get the list of available commands.

@gmegidish
gmegidish merged commit d464822 into main Sep 1, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant