executor: clean finalized runc mount stubs - #7033
Closed
teamleaderleo wants to merge 1 commit into
Closed
Conversation
BuildKit records mount-stub cleanup before rootless conversion finishes changing the mount list, which can leave rootful and rootless builds with different empty directories. This change registers cleanup after rootless conversion, when the mount list is final, and uses that list for cleanup. Signed-off-by: Leo Li <cheerleaderleo@outlook.com>
Member
|
replaced by #7039 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6686
BuildKit currently decides which mount stubs to clean before rootless conversion finishes changing the mount list, which can leave rootful and rootless builds with different empty directories in the image.
This change registers cleanup after rootless conversion, when the mount list is final, and uses that list for cleanup.
The regression test covers the rootless case.