[game] Implement a shared physical-combat core

[vrifftech]

Summary

This PR establishes one common physical-combat implementation for both supported games. It covers attack results, authoritative attack and Defense inputs, typed damage construction, mitigation, delayed melee impacts, visibility-aware Defense, equipped mitigation, feedback, and damage-event context.

Common runtime path

runtime ability / feat / effect provenance inputs
→ attack result and critical state
→ authoritative Defense
→ source-qualified typed damage packet
→ immunity / resistance / reduction
→ per-impact melee result delivery
→ feedback and object damage-event context

Architectural changes

• Uses one game-neutral effect provenance representation and source-key encoder.
• Uses one source/subtype reducer for effective abilities, attack modifiers, and damage modifiers.
• Uses the common active-effect list for equipped resistance and reduction.
• Uses one exact queued-user-action target validator.
• Uses one visibility and counter lifecycle.
• Uses one melee animation-selection module and one per-impact delivery schedule.

[modawan]

Looks good to me overall, thank you! Lots of improvements here.

[modawan]

GetSimpleAlignmentGoodEvil

There is no such function. Looks like nGoodEvil is handled in effect->appliesVersus(target).

[modawan]

Is there any significance to these values? 0x3e, 0x3f, etc.

[modawan]

I'm not sure how this code works. So damage type is a bitmask of electrical, fire, energy, etc.
(flags & (flags - 1)) == 0 seems to check that only 1 bit is set, and then the loop finds the bit number (damage type) and moves all damage to the corresponding bucket (damageAmounts).

What happens when damage type is "universal" (0xFFFF, all bits are 1)?

[modawan]

What is the purpose of _lastTarget? It seems to be set for any combat attack, object selection, party member add, leader change, but only ever used to inhibit FloatingText::addHeal:

void FloatingText::addHeal(const Object &object, int amount) {
    if (!_game.party().isMember(object) &&
        _game.lastTarget() != object.id()) {
        return;
    }

    add(object, std::to_string(amount), Style::Heal);
}

[modawan]

Is there anything in the game that depends on this quirk?

[modawan]

What Effect::onApply is generally supposed to do? Here it checks that the effect is applied.
However, BonusFeatEffect::onApply actually applies the effect:

bool BonusFeatEffect::onApply(Object &object) {
    auto *creature = dyn_cast<Creature>(&object);
    if (!creature || _feat == FeatType::Invalid) {
        return false;
    }
    creature->addBonusFeat(_feat);
    return true;
}

What is the difference between onApply and applyTo?

[modawan]

Looks like the second check is excessive - the player character is also a party member, so isMember should return true.

[modawan]

I think it is better to read the 2DA file into a structure during initialization. Otherwise we do lookup and validation for every damage event. Also, I guess there are more modifiers that we'll need to use.

[modawan]

So it is similar to the code in DamageEffect constructor. Splitting damage into individial buckets for each type does not play with this routine it seems. If we keep flags as a bitmask, we can fold this into something like (_lastDamageAmounts.flags & damageFlags) ? _lastDamageAmounts.value : 0

[modawan]

Do we need to run OnNotice script here?