[game] Run OnUsed scripts on locked containers - #326
Open
modawan wants to merge 1 commit into
Open
Conversation
Before the patch, Module::onPlaceableClick completely skipped locked containers. This does not work for the spice container on the Ebon Hawk in K1. Spice container is locked, but attempting to open it should trigger its OnLoad, which starts a dialogue to enter the code. With the patch, we use OpenContainerAction on both locked and unlocked containers. The player character navigates to the container before calling OnUsed. If the container is locked, it returns early and does not open the container.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before the patch,
Module::onPlaceableClickcompletely skipped lockedcontainers. This does not work for the spice container on the Ebon
Hawk in K1. Spice container is locked, but attempting to open it
should trigger its
OnLoad, which starts a dialogue to enter the code.With the patch, we use
OpenContainerActionon both locked and unlockedcontainers. The player character navigates to the container before
calling
OnUsed. If the container is locked, it returns early and doesnot open the container.