Skip to content

Fix warnings: DeprecationWarning and prints use warnings.warn.#22

Closed
irm-codebase wants to merge 1 commit into
mainfrom
fix/print-to-warn
Closed

Fix warnings: DeprecationWarning and prints use warnings.warn.#22
irm-codebase wants to merge 1 commit into
mainfrom
fix/print-to-warn

Conversation

@irm-codebase

@irm-codebase irm-codebase commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

Small PR with some fixes:

  • print messages in disaggregate.py now use python's warn so stderr catches them.
  • DeprecationWarning was a "dead" case due to the use of raise, later code was unreachable. It is now a warning of the correct type, so the code continues, implementing the fix after the warning.
  • added **/tmp/* to .gitignore so test code files do not show up in git.

@irm-codebase irm-codebase requested a review from jnnr June 15, 2026 17:23
@irm-codebase

Copy link
Copy Markdown
Contributor Author

@jnnr: I experienced some issues when testing locally. The test_performance_disaggregate_to_raster would not finish. Perhaps I did not set something correctly on my side?

The change should be benign, it does not touch core logic.

@jnnr

jnnr commented Jun 24, 2026

Copy link
Copy Markdown
Collaborator

Thanks for pointing to this, @irm-codebase! I agree with the warning. The print statements are rather informational and not warnings, so I rather convert them to logger.info. I take this with other pre-release clean-ups here #25. Let me know if you have objections.

@jnnr jnnr closed this Jun 24, 2026
@jnnr jnnr deleted the fix/print-to-warn branch June 24, 2026 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants