mcp: avoid panic for new-protocol null IDs#1046
Open
cyphercodes wants to merge 1 commit into
Open
Conversation
Guard the per-request protocol version check so notification-shaped messages with new-protocol metadata do not dereference nil initialize params. This lets malformed id:null calls continue to the existing request validation path instead of crashing. Fixes modelcontextprotocol#1043
This comment was marked as spam.
This comment was marked as spam.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a panic in the server-side per-request protocol metadata path when an inbound message has
id: nulland new-protocol_meta.The request decodes as notification-shaped, so
validateRequestMetareturns new-protocol metadata without initialize params. Guard the protocol-version check before reading initialize params, allowing the existing request validation path to reject the malformed call instead of dereferencing nil.Tests:
go test ./mcp -run 'Test(ServerHandleNewProtocolNullID|ValidateRequestMeta)$' -count=1go test ./mcp -count=1git diff --check HEAD~1..HEADFixes #1043