fix(mcp): guard nil initializeParams on id:null with new-protocol _meta#1048
Open
kuangmi-bit wants to merge 1 commit into
Open
fix(mcp): guard nil initializeParams on id:null with new-protocol _meta#1048kuangmi-bit wants to merge 1 commit into
kuangmi-bit wants to merge 1 commit into
Conversation
When a request carries id:null (IsCall() returns false), validateRequestMeta returns initializeParams=nil but usesNewProtocol=true. The subsequent protocol-version check dereferences the nil pointer, causing SIGSEGV. Add a nil guard matching the pattern already used at the initialization check (line 1846). Regression test exercises completion/complete, prompts/get, and tools/call with id:null + new-protocol _meta — all three previously panicked before the fix. Fixes modelcontextprotocol#1043
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When an inbound JSON-RPC frame carries
"id": nullwith per-request_metafor protocol version2026-07-28, the server panics with SIGSEGV (nil pointer dereference oninitializeParams.ProtocolVersion).The root cause is a two-step gap:
validateRequestMetareturnsinitializeParams: nil, usesNewProtocol: truewhenreq.IsCall()returns false (triggered byid: null).ServerSession.handledereferencesinitializeParams.ProtocolVersionwithout checking for nil.Fixes: #1043
Fix
One-line nil guard at
server.go:1815, matching the pattern already used on line 1846:Test
Regression test exercises three methods (
completion/complete,prompts/get,tools/call) withid: null+ new-protocol_meta— all three previously panicked, now return gracefully.