Repository navigation
chore(deps): bump org.jetbrains.kotlinx:kotlinx-serialization-json from 1.11.0 to 1.12.0 in /samples/kotlinlang-mcp-server - #1138
Conversation
There was a problem hiding this comment.
Looks good — happy to approve this one!
Produced by Air Automations. Name: Code review / Run: https://air.jetbrains.cloud/org/05cf1a7f-6ab5-713b-abd3-29d0c8a05e2d/automations/409567ec-d3a7-40ac-ba95-8518ec577ac2?run=bfac79f0-2e07-49ef-9c6f-2f2d2f7407f5
|
@dependabot rebase |
212d2ea to
244bb53
Compare
There was a problem hiding this comment.
Looks good — happy to approve this one!
Produced by Air Automations. Name: Code review / Run: https://air.jetbrains.cloud/org/05cf1a7f-6ab5-713b-abd3-29d0c8a05e2d/automations/409567ec-d3a7-40ac-ba95-8518ec577ac2?run=f468d2ad-f611-4c60-aab7-07af0c6e88bb
|
@dependabot rebase |
Bumps [org.jetbrains.kotlinx:kotlinx-serialization-json](https://github.com/Kotlin/kotlinx.serialization) from 1.11.0 to 1.12.0. - [Release notes](https://github.com/Kotlin/kotlinx.serialization/releases) - [Changelog](https://github.com/Kotlin/kotlinx.serialization/blob/master/CHANGELOG.md) - [Commits](Kotlin/kotlinx.serialization@v1.11.0...v1.12.0) --- updated-dependencies: - dependency-name: org.jetbrains.kotlinx:kotlinx-serialization-json dependency-version: 1.12.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
244bb53 to
7e1d7de
Compare
| ktor = "3.6.0" | ||
| mcp-kotlin = "0.15.0" | ||
| serialization = "1.11.0" | ||
| serialization = "1.12.0" |
There was a problem hiding this comment.
Problem: this sample is watched by Dependabot (.github/dependabot.yml covers /samples/*) but is absent from both CI sample matrices — .github/workflows/samples.yml and the samples job in .github/workflows/build.yml both list only kotlin-mcp-client, kotlin-mcp-server, simple-streamable-server, weather-stdio-server. No check on this PR compiles or tests the module this line belongs to.
Failure scenario: ./gradlew build in samples/kotlinlang-mcp-server fails right now — KotlinlangServerTest > server registers both tools with correct schema and annotations fails with McpException: Request timed out on Initialize. I reproduced it identically with serialization = "1.11.0" and "1.12.0", so this bump is not the cause; the point is that a red build has been sitting on main unnoticed, and every future bump in this directory will merge on green checks that never built the sample.
Suggested fix: add kotlinlang-mcp-server to the matrix.sample lists in both workflows (and address the pre-existing test failure separately). If the sample is intentionally excluded from CI, exclude it from Dependabot as well, so bumps here don't arrive unverifiable.
Produced by Air Automations. Name: Code review / Run: https://air.jetbrains.cloud/org/05cf1a7f-6ab5-713b-abd3-29d0c8a05e2d/automations/409567ec-d3a7-40ac-ba95-8518ec577ac2?run=56e7e914-d913-4445-9a20-f68a11c12a61
Bumps org.jetbrains.kotlinx:kotlinx-serialization-json from 1.11.0 to 1.12.0.
Release notes
Sourced from org.jetbrains.kotlinx:kotlinx-serialization-json's releases.
... (truncated)
Changelog
Sourced from org.jetbrains.kotlinx:kotlinx-serialization-json's changelog.
... (truncated)
Commits
4c28c3e1.12.0 release (#3295)abe8a96Merge remote-tracking branch 'origin/master' into dev952d17aAdded Gradle task to prepare release (#3279)6f30025Remove Play verification files (#3266)89b23caWorkaround watchosArm32 removal (#3291)53932a0Update links to Okio site and its docs (#3292)3a5db3bReduce the number of input fields for bug report9ede0e2Added templates to the issue creation wizard5d3f884Update Dokka to version 2.3.0-Beta (#3286)1fe9a49Suppress deprecation of nodejs in wasmWasi configuration (#3287)