Skip to content

Prepare for CI: Electrical.Machines - #4788

Merged
AHaumer merged 2 commits into
modelica:masterfrom
AHaumer:PrepCI_ElMa
Sep 5, 2026
Merged

Prepare for CI: Electrical.Machines#4788
AHaumer merged 2 commits into
modelica:masterfrom
AHaumer:PrepCI_ElMa

Conversation

@AHaumer

@AHaumer AHaumer commented May 20, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Reducing the size of Reference Results
Similar procedure as #4775 and #4787

@AHaumer AHaumer added L: Electrical.Machines Issue addresses Modelica.Electrical.Machines ref-result Issue addresses the reference results labels May 20, 2026
@AHaumer AHaumer changed the title Prepare CI of Electrical.Machines Prepare for CI of Electrical.Machines May 20, 2026
@AHaumer AHaumer changed the title Prepare for CI of Electrical.Machines Prepare for CI: Electrical.Machines May 20, 2026
@AHaumer AHaumer mentioned this pull request May 20, 2026
Merged
HansOlsson
HansOlsson reviewed May 27, 2026
View reviewed changes

@HansOlsson HansOlsson left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this is correct, but I would prefer input from the ones doing the CI-testing.

This was referenced Jun 3, 2026
Closed
Closed
@MatthiasBSchaefer

MatthiasBSchaefer commented Jun 3, 2026

Copy link
Copy Markdown
Contributor

The comparison of the adapted examples of Modelica.Electrical.Machines with the existing MAP-LIB-ReferenceResults here:

https://www.ltx.de/download/MA/PR_Testing/PR4788/Modelica/testrun_report.html

and the comparison of the new examples of ModelicaTest.Electrical.Machines with the existing MAP-LIB-ReferenceResults here:
https://www.ltx.de/download/MA/PR_Testing/PR4788/ModelicaTest/testrun_report.html
Please consider that this is a comparison of new examples inside ModelicaTest with the ReferenceResults of the corresponding MODELICA examples, they are extended from.

Therefore i used a modified CSV-Comparison Tool (modelica-tools/csv-compare#80, modelica-tools/csv-compare#81)

MatthiasBSchaefer
MatthiasBSchaefer approved these changes Jun 3, 2026
View reviewed changes

@MatthiasBSchaefer MatthiasBSchaefer left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@MatthiasBSchaefer MatthiasBSchaefer mentioned this pull request Jun 9, 2026
Merged
@AHaumer
AHaumer merged commit cc887de into modelica:master Sep 5, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@HansOlsson HansOlsson HansOlsson left review comments
@MatthiasBSchaefer MatthiasBSchaefer MatthiasBSchaefer approved these changes
@maltelenz maltelenz Awaiting requested review from maltelenz
@christiankral christiankral Awaiting requested review from christiankral
@casella casella Awaiting requested review from casella
@GallLeo GallLeo Awaiting requested review from GallLeo
@henrikt-ma henrikt-ma Awaiting requested review from henrikt-ma
@StephanZiegler StephanZiegler Awaiting requested review from StephanZiegler

Assignees

No one assigned

Labels

L: Electrical.Machines Issue addresses Modelica.Electrical.Machines ref-result Issue addresses the reference results

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@AHaumer @MatthiasBSchaefer @HansOlsson